From: Stephen Hemminger <stephen@networkplumber.org>
To: Shinae Woo <shinae@alkira.net>
Cc: dev@dpdk.org
Subject: Re: [PATCH] linux/igb_uio: make module parameters visible in sysfs
Date: Tue, 31 Oct 2023 09:59:44 -0700 [thread overview]
Message-ID: <20231031095944.17f7d3a8@fedora> (raw)
In-Reply-To: <20220821231950.5957-1-shinae@alkira.net>
On Sun, 21 Aug 2022 16:19:50 -0700
Shinae Woo <shinae@alkira.net> wrote:
> diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
> index 33e0e02..c927ae6 100644
> --- a/linux/igb_uio/igb_uio.c
> +++ b/linux/igb_uio/igb_uio.c
> @@ -44,7 +44,7 @@ struct rte_uio_pci_dev {
> };
>
> static int wc_activate;
> -static char *intr_mode;
> +static char *intr_mode = RTE_INTR_MODE_MSIX_NAME;
Since intr_mode is now initialized you can remove the code that checks for
it being NULL.
diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
index aea67da..11141d4 100644
--- a/linux/igb_uio/igb_uio.c
+++ b/linux/igb_uio/igb_uio.c
@@ -44,7 +44,7 @@ struct rte_uio_pci_dev {
};
static int wc_activate;
-static char *intr_mode;
+static char *intr_mode = RTE_INTR_MODE_MSIX_NAME;
static enum rte_intr_mode igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX;
/* sriov sysfs */
static ssize_t
@@ -591,11 +591,6 @@ igbuio_pci_remove(struct pci_dev *dev)
static int
igbuio_config_intr_mode(char *intr_str)
{
- if (!intr_str) {
- pr_info("Use MSIX interrupt by default\n");
- return 0;
- }
-
if (!strcmp(intr_str, RTE_INTR_MODE_MSIX_NAME)) {
igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX;
pr_info("Use MSIX interrupt\n");
next prev parent reply other threads:[~2023-10-31 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 23:19 Shinae Woo
2023-10-31 16:59 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-21 22:12 Shinae Woo
2023-07-06 2:40 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031095944.17f7d3a8@fedora \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=shinae@alkira.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).