From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C33C43255; Tue, 31 Oct 2023 21:46:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 954BF40DCE; Tue, 31 Oct 2023 21:46:43 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id B812D40294 for <dev@dpdk.org>; Tue, 31 Oct 2023 21:46:42 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-27d0e3d823fso4431021a91.1 for <dev@dpdk.org>; Tue, 31 Oct 2023 13:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1698785202; x=1699390002; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gFVGJi08XTVnfRkzUEQs8UC4VwaR61ZATmEU33gJDYw=; b=Ouvx9aaegwKN8GAKuRQgx+QVXhLIL20bIExjtIMrOQBzm4LDiF0z9e+MDkM62Ecuq/ 6OPQ0rM7BOgTtgfY3l7O5ni+pLp9qD3pvndX543uRKEU9e3RLNXJCS6OeHZa+gidN4uF SRH6Ss+RxmTbgFpDGRibs4QFnHR/RrEEejGYx71fMfQ16Xy/WIjBLQE+ypSoPMZX4xIt zlBdfOZgDsY0a/VGGHJFQ6bBZec/MWy87K8ZBRsKg5CjpGSJU4Cyy/lE5OrannN9fu5/ nZE06vLSsoJd5liPE8fJ5w1r7RTCCBgoLF3/dgohZSC6VBkJ+6038y0xAAcQJiF9YfOP eSnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698785202; x=1699390002; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gFVGJi08XTVnfRkzUEQs8UC4VwaR61ZATmEU33gJDYw=; b=xNAGwsbi9xASfpBzknU2a8P/3smX+tCfaGDRtexHXFTP/P2UcYkAqSyJc28feA/7Jw kFbtufeEDOizVdUcx3RWdJ5rMO0qzNHh68HUsTRoZ/IC1Uz7gpqMsBQk2wNb/IPy3Kx/ cV+R6DcJzD0iT6pQCwzY+YBArkY8fRJ2OY+g+pAtlCt0WXlAD6YiAoL57nX7UZHsECSB 93vxxFVtCld/cm+ppWJONvcci+NdS6+dgTXFBKA4lPil7MlNb/kmw8Y94+kt2IAglMEp nqRFMEG7Rv4oFm9B0Tf3PHjvTE3L+A9kyRBgw5x0xrmNIFFx84EsVYE52r4itu6Mxlo7 HuTA== X-Gm-Message-State: AOJu0YxXV+8SngeEfPWjWOfQFxjw7x38U8Cte1Xbim78XFLGbyW6XWoM IzQvh/UI8n44D+7rtreJ6uWQQQ== X-Google-Smtp-Source: AGHT+IH9xyuA8YHeQu7/qK0Pq03yzcVX3Hy+C3JrzzYtPY6zMoGZH89PkJz51Ll6AQ16WSXGbeXcPA== X-Received: by 2002:a17:90b:111:b0:27d:1339:9176 with SMTP id p17-20020a17090b011100b0027d13399176mr11157434pjz.25.1698785201809; Tue, 31 Oct 2023 13:46:41 -0700 (PDT) Received: from fedora ([38.142.2.14]) by smtp.gmail.com with ESMTPSA id 14-20020a17090a018e00b0026b3f76a063sm1616708pjc.44.2023.10.31.13.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 13:46:40 -0700 (PDT) Date: Tue, 31 Oct 2023 13:46:38 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Ferruh Yigit <ferruh.yigit@amd.com> Cc: fengchengwen <fengchengwen@huawei.com>, thomas@monjalon.net, dev@dpdk.org Subject: Re: [PATCH v2 00/44] fix segment fault when parse args Message-ID: <20231031134638.2855f9c8@fedora> In-Reply-To: <1c49ce5b-4109-8621-ee9e-4a9f575280ee@amd.com> References: <20230314124813.39521-1-fengchengwen@huawei.com> <20230320092110.37295-1-fengchengwen@huawei.com> <957bcf61-090d-a0ed-afb1-94897993bcb2@huawei.com> <1c49ce5b-4109-8621-ee9e-4a9f575280ee@amd.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, 17 Apr 2023 17:37:46 +0100 Ferruh Yigit <ferruh.yigit@amd.com> wrote: > From: Ferruh Yigit <ferruh.yigit@amd.com> > To: fengchengwen <fengchengwen@huawei.com>, thomas@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 00/44] fix segment fault when parse args > Date: Mon, 17 Apr 2023 17:37:46 +0100 > User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 > Thunderbird/102.10.0 > > On 4/15/2023 2:38 AM, fengchengwen wrote: > > Hi Thomas, Ferruh, > > > > This patch-set get almost 30% ack by PMD's maintainer. > > Could it be applied? and squeeze the patch-set is okay. > > > > Hi Chengwen, > > The patch is trivial and safe on its own, so for me having enough ack or > not is not what blocks the set. > > As we discussed before, instead of adding NULL checks to the callbacks, > it is better to handle this in the kvargs API level, that discussion is > holding this patchset back. > > According result of discussion we may prefer to not merge this patch at all. Agree. Hitting so many places, and not sure that all of them are covered, is an indicator it should be solved at higher level.