From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: "Matan Azrad" <matan@nvidia.com>,
"Viacheslav Ovsiienko" <viacheslavo@nvidia.com>,
"Tyler Retzlaff" <roretzla@linux.microsoft.com>,
"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: [PATCH] vdpa/mlx5: revert event thread to normal priority
Date: Tue, 31 Oct 2023 15:57:56 +0100 [thread overview]
Message-ID: <20231031145756.517091-1-thomas@monjalon.net> (raw)
When converting to rte_thread API, the SCHED_RR policy
has been translated into RTE_THREAD_PRIORITY_REALTIME_CRITICAL.
But SCHED_RR was not effective prior to this conversion because
PTHREAD_EXPLICIT_SCHED attribute was missing initially.
Using the default priority RTE_THREAD_PRIORITY_NORMAL
should revert to the original behaviour.
By the way, RTE_THREAD_PRIORITY_REALTIME_CRITICAL is difficult
to manage properly and is allowed only on Windows so far.
Fixes: a7ba40b2b1bf ("drivers: convert to internal control threads")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/vdpa/mlx5/mlx5_vdpa_event.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
index fa26471b18..9557c1042e 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
@@ -514,7 +514,6 @@ mlx5_vdpa_cqe_event_setup(struct mlx5_vdpa_priv *priv)
DRV_LOG(ERR, "Failed to initialize thread attributes");
goto out;
}
- attr.priority = RTE_THREAD_PRIORITY_REALTIME_CRITICAL;
if (priv->event_core != -1)
CPU_SET(priv->event_core, &attr.cpuset);
else
--
2.42.0
next reply other threads:[~2023-10-31 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 14:57 Thomas Monjalon [this message]
2023-11-02 9:57 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031145756.517091-1-thomas@monjalon.net \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=matan@nvidia.com \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).