* [PATCH] vdpa/mlx5: revert event thread to normal priority
@ 2023-10-31 14:57 Thomas Monjalon
2023-11-02 9:57 ` Maxime Coquelin
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Monjalon @ 2023-10-31 14:57 UTC (permalink / raw)
To: dev
Cc: Matan Azrad, Viacheslav Ovsiienko, Tyler Retzlaff,
Konstantin Ananyev, Andrew Rybchenko, Morten Brørup
When converting to rte_thread API, the SCHED_RR policy
has been translated into RTE_THREAD_PRIORITY_REALTIME_CRITICAL.
But SCHED_RR was not effective prior to this conversion because
PTHREAD_EXPLICIT_SCHED attribute was missing initially.
Using the default priority RTE_THREAD_PRIORITY_NORMAL
should revert to the original behaviour.
By the way, RTE_THREAD_PRIORITY_REALTIME_CRITICAL is difficult
to manage properly and is allowed only on Windows so far.
Fixes: a7ba40b2b1bf ("drivers: convert to internal control threads")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/vdpa/mlx5/mlx5_vdpa_event.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
index fa26471b18..9557c1042e 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
@@ -514,7 +514,6 @@ mlx5_vdpa_cqe_event_setup(struct mlx5_vdpa_priv *priv)
DRV_LOG(ERR, "Failed to initialize thread attributes");
goto out;
}
- attr.priority = RTE_THREAD_PRIORITY_REALTIME_CRITICAL;
if (priv->event_core != -1)
CPU_SET(priv->event_core, &attr.cpuset);
else
--
2.42.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] vdpa/mlx5: revert event thread to normal priority
2023-10-31 14:57 [PATCH] vdpa/mlx5: revert event thread to normal priority Thomas Monjalon
@ 2023-11-02 9:57 ` Maxime Coquelin
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Coquelin @ 2023-11-02 9:57 UTC (permalink / raw)
To: Thomas Monjalon, dev
Cc: Matan Azrad, Viacheslav Ovsiienko, Tyler Retzlaff,
Konstantin Ananyev, Andrew Rybchenko, Morten Brørup
On 10/31/23 15:57, Thomas Monjalon wrote:
> When converting to rte_thread API, the SCHED_RR policy
> has been translated into RTE_THREAD_PRIORITY_REALTIME_CRITICAL.
> But SCHED_RR was not effective prior to this conversion because
> PTHREAD_EXPLICIT_SCHED attribute was missing initially.
>
> Using the default priority RTE_THREAD_PRIORITY_NORMAL
> should revert to the original behaviour.
>
> By the way, RTE_THREAD_PRIORITY_REALTIME_CRITICAL is difficult
> to manage properly and is allowed only on Windows so far.
>
> Fixes: a7ba40b2b1bf ("drivers: convert to internal control threads")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> drivers/vdpa/mlx5/mlx5_vdpa_event.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> index fa26471b18..9557c1042e 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> @@ -514,7 +514,6 @@ mlx5_vdpa_cqe_event_setup(struct mlx5_vdpa_priv *priv)
> DRV_LOG(ERR, "Failed to initialize thread attributes");
> goto out;
> }
> - attr.priority = RTE_THREAD_PRIORITY_REALTIME_CRITICAL;
> if (priv->event_core != -1)
> CPU_SET(priv->event_core, &attr.cpuset);
> else
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-02 9:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-31 14:57 [PATCH] vdpa/mlx5: revert event thread to normal priority Thomas Monjalon
2023-11-02 9:57 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).