From: Mingjin Ye <mingjinx.ye@intel.com>
To: dev@dpdk.org
Cc: qiming.yang@intel.com, yidingx.zhou@intel.com,
Mingjin Ye <mingjinx.ye@intel.com>,
stable@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>
Subject: [PATCH v3] net/ice: fix crash on closing representor ports
Date: Wed, 1 Nov 2023 10:13:47 +0000 [thread overview]
Message-ID: <20231101101347.3570418-1-mingjinx.ye@intel.com> (raw)
In-Reply-To: <20231030084459.3470038-1-mingjinx.ye@intel.com>
The data resource in struct rte_eth_dev is cleared and points to NULL
when the DCF port is closed.
If the DCF representor port is closed after the DCF port is closed,
a segmentation fault occurs because the representor port accesses
the data resource released by the DCF port.
This patch checks if the resource is present before accessing.
Fixes: 5674465a32c8 ("net/ice: add DCF VLAN handling")
Fixes: da9cdcd1f372 ("net/ice: fix crash on representor port closing")
Cc: stable@dpdk.org
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
v3: New solution.
---
drivers/net/ice/ice_dcf_vf_representor.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ice/ice_dcf_vf_representor.c b/drivers/net/ice/ice_dcf_vf_representor.c
index b9fcfc80ad..8c45e28f02 100644
--- a/drivers/net/ice/ice_dcf_vf_representor.c
+++ b/drivers/net/ice/ice_dcf_vf_representor.c
@@ -111,14 +111,16 @@ ice_dcf_vf_repr_link_update(__rte_unused struct rte_eth_dev *ethdev,
static __rte_always_inline struct ice_dcf_hw *
ice_dcf_vf_repr_hw(struct ice_dcf_vf_repr *repr)
{
- struct ice_dcf_adapter *dcf_adapter =
- repr->dcf_eth_dev->data->dev_private;
+ struct rte_eth_dev_data *dcf_data = repr->dcf_eth_dev->data;
+ struct ice_dcf_adapter *dcf_adapter;
- if (!dcf_adapter) {
+ if (!dcf_data || !dcf_data->dev_private) {
PMD_DRV_LOG(ERR, "DCF for VF representor has been released\n");
return NULL;
}
+ dcf_adapter = dcf_data->dev_private;
+
return &dcf_adapter->real_hw;
}
--
2.25.1
next prev parent reply other threads:[~2023-11-01 10:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 9:51 [PATCH] net/iavf: " Mingjin Ye
2023-10-27 7:17 ` David Marchand
2023-10-30 2:35 ` [PATCH v2] " Mingjin Ye
2023-10-30 8:44 ` [PATCH v2] net/ice: " Mingjin Ye
2023-11-01 1:11 ` Zhang, Qi Z
2023-11-01 10:13 ` Mingjin Ye [this message]
2023-11-01 10:48 ` [PATCH v3] " Zhang, Qi Z
2023-11-02 2:38 ` Ye, MingjinX
2023-11-02 3:59 ` Zhang, Qi Z
2023-11-02 10:11 ` [PATCH v4] " Mingjin Ye
2023-11-06 1:23 ` Zhang, Qi Z
2023-11-06 10:00 ` [PATCH v5] " Mingjin Ye
2023-11-06 12:05 ` Zhang, Qi Z
2023-11-07 10:12 ` [PATCH v6] " Mingjin Ye
2023-11-07 12:18 ` Zhang, Qi Z
2023-11-08 11:39 ` [PATCH v7] " Mingjin Ye
2023-11-09 0:26 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101101347.3570418-1-mingjinx.ye@intel.com \
--to=mingjinx.ye@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).