DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Chaoyong He <chaoyong.he@corigine.com>,
	Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: [PATCH 2/2] net/nfp: fix calloc parameters
Date: Thu, 2 Nov 2023 13:08:47 +0000	[thread overview]
Message-ID: <20231102130847.3367102-2-ferruh.yigit@amd.com> (raw)
In-Reply-To: <20231102130847.3367102-1-ferruh.yigit@amd.com>

gcc [1] generates warning [2] about calloc usage, because calloc
parameter order is wrong, fixing it by replacing parameters.

[1]
gcc (GCC) 14.0.0 20231102 (experimental)

[2]
Compiling C object .../net_nfp_nfpcore_nfp_mutex.c.o
.../net/nfp/nfpcore/nfp_mutex.c: In function ‘nfp_cpp_mutex_alloc’:
../drivers/net/nfp/nfpcore/nfp_mutex.c:171:15:
  warning: allocation of insufficient size ‘1’ for type
           ‘struct nfp_cpp_mutex’ with size ‘48’ [-Walloc-size]
  171 |         mutex = calloc(sizeof(*mutex), 1);
      |               ^

Fixes: c7e9729da6b5 ("net/nfp: support CPP")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
Cc: alejandro.lucero@netronome.com
---
 drivers/net/nfp/nfpcore/nfp_mutex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfpcore/nfp_mutex.c b/drivers/net/nfp/nfpcore/nfp_mutex.c
index 3c10c7a090c0..edb78dfdc917 100644
--- a/drivers/net/nfp/nfpcore/nfp_mutex.c
+++ b/drivers/net/nfp/nfpcore/nfp_mutex.c
@@ -168,7 +168,7 @@ nfp_cpp_mutex_alloc(struct nfp_cpp *cpp,
 	if (tmp != key)
 		return NULL;
 
-	mutex = calloc(sizeof(*mutex), 1);
+	mutex = calloc(1, sizeof(*mutex));
 	if (mutex == NULL)
 		return NULL;
 
-- 
2.34.1


  reply	other threads:[~2023-11-02 13:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 13:08 [PATCH 1/2] pipeline: " Ferruh Yigit
2023-11-02 13:08 ` Ferruh Yigit [this message]
2023-11-03  1:26   ` [PATCH 2/2] net/nfp: " Chaoyong He
2023-11-06 14:26 ` [PATCH 1/2] pipeline: " Dumitrescu, Cristian
2024-01-24 18:53 ` [PATCH v2 1/8] " Ferruh Yigit
2024-01-24 18:53   ` [PATCH v2 2/8] net/nfp: " Ferruh Yigit
2024-01-24 19:01     ` Morten Brørup
2024-01-24 18:54   ` [PATCH v2 3/8] rawdev: " Ferruh Yigit
2024-01-24 18:59     ` Morten Brørup
2024-01-25  2:34     ` fengchengwen
2024-01-25  3:39     ` Hemant Agrawal
2024-01-24 18:54   ` [PATCH v2 4/8] eventdev: " Ferruh Yigit
2024-01-24 18:59     ` Morten Brørup
2024-01-25  2:34     ` fengchengwen
2024-01-24 18:54   ` [PATCH v2 5/8] dmadev: " Ferruh Yigit
2024-01-24 18:59     ` Morten Brørup
2024-01-25  2:35     ` fengchengwen
2024-01-24 18:54   ` [PATCH v2 6/8] common/mlx5: " Ferruh Yigit
2024-01-24 19:01     ` Morten Brørup
2024-01-26 10:12       ` Dariusz Sosnowski
2024-01-24 18:54   ` [PATCH v2 7/8] net/bnx2x: " Ferruh Yigit
2024-01-24 19:01     ` Morten Brørup
2024-01-24 18:54   ` [PATCH v2 8/8] net/sfc: " Ferruh Yigit
2024-01-24 19:02     ` Morten Brørup
2024-01-25  7:10       ` Andrew Rybchenko
2024-01-24 19:00   ` [PATCH v2 1/8] pipeline: " Morten Brørup
2024-02-18 16:08   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231102130847.3367102-2-ferruh.yigit@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).