From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DE0C43272; Thu, 2 Nov 2023 22:57:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8992440262; Thu, 2 Nov 2023 22:56:59 +0100 (CET) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id CCD2D40144 for <dev@dpdk.org>; Thu, 2 Nov 2023 22:56:57 +0100 (CET) Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6b5e6301a19so1525569b3a.0 for <dev@dpdk.org>; Thu, 02 Nov 2023 14:56:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1698962217; x=1699567017; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fvnyl2OCZV8m2RR+ZUi8mcepcvw8xXgHrXEbwDU8WHI=; b=3cqaDvssvX6o4qIneNMkMmNmD3CELH4GflXuKORDhZ9QJpvJB9On2knb8l1Yq7V73i TOhenKiUSbVk/2Xzm6EwA09tB4wZIxsRMgZhi6Xu7iiBCpmpOoi1Ta+Gi+9bpeMnUpMb W6U4alVuiE3n4XwIZBBakPwNO0s5feDMGNC/wHT9sRKv2ThHCsHuk79FjzJlGcl6JDxj Xc6anCWHQNY9M7pn9rWbNwJBUHt92A+KDYHNxM5VrdZnIwXaji4I1ZwEvEbyYWg5v6fZ SAVIeXF8gTcoycRdlk7Fq0nlN78uBK3HYhnSQn7+whXDjT9WVnJs7Ug+iNWwxY0OZVa6 E+HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698962217; x=1699567017; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fvnyl2OCZV8m2RR+ZUi8mcepcvw8xXgHrXEbwDU8WHI=; b=fDkkUaliFbXVwLGBmxzb7m8O6LFlVzEaZdr5BuMQQL1Z8SkgAYITF5/rWpnMep5EBl oCU/TV3+e05MvQ5bbcIpbALto4667J/UBXWsVU9882p4KoS1SS02GLiQOwYfp+AMEPPj Nng+pIrN8lUsopqj5CjaNbDm0GvenaLfSXX221psC8m365HPJQ0NUJAdpVyWBplnv2nW av3A8EWzpKDojWhW6a5BefO4QCGVzNmAK78J1ASyP2Oi9cuZqIr1TbEMpMg1PJw5pVvD BHqN/uq4B6yWDFQav+zLYlK+31As8eETjSGpp0MUAOPuUMqbpqcObeAibGmtJghXCmDJ 131Q== X-Gm-Message-State: AOJu0YwIND315CdIcoONHpyGn6BhTTS/RiC1xP4EfzoAoj7WfF0ghYmI VfvEqBkIZGkLzeoI80friun+Yg== X-Google-Smtp-Source: AGHT+IEt3+mc7Q+S2Db3QKA0aIc1Umydvmk58+0a0QTV2/lAyKT1BJymgb49Ynog/RpQpXuwKTVqNg== X-Received: by 2002:a05:6a00:2494:b0:6bd:f760:6a9d with SMTP id c20-20020a056a00249400b006bdf7606a9dmr25713800pfv.14.1698962216754; Thu, 02 Nov 2023 14:56:56 -0700 (PDT) Received: from fedora ([38.142.2.14]) by smtp.gmail.com with ESMTPSA id n31-20020a056a000d5f00b006c052bb7da5sm205924pfv.7.2023.11.02.14.56.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 14:56:56 -0700 (PDT) Date: Thu, 2 Nov 2023 14:56:53 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Ferruh Yigit <ferruh.yigit@amd.com> Cc: dev@dpdk.org Subject: Re: [PATCH v6 3/3] net/tap; rebuild and update the BPF flow program Message-ID: <20231102145653.4249eace@fedora> In-Reply-To: <392b0618-d959-4518-8844-1f9084520271@amd.com> References: <20230716212544.5625-1-stephen@networkplumber.org> <20231101180526.214773-1-stephen@networkplumber.org> <20231101180526.214773-4-stephen@networkplumber.org> <392b0618-d959-4518-8844-1f9084520271@amd.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Thu, 2 Nov 2023 21:00:31 +0000 Ferruh Yigit <ferruh.yigit@amd.com> wrote: > On 11/1/2023 6:02 PM, Stephen Hemminger wrote: > > Rebuild with commit > > c0335cc197 (tap; rebuild and update the BPF flow program, 2023-10-31) > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > --- > > drivers/net/tap/tap_bpf_insns.h | 2959 ++++++++++++++++--------------- > > 1 file changed, 1503 insertions(+), 1456 deletions(-) > > > > When I generate the header file, it is different than the one in this > commit, is this expected? > Output depends on compiler version of clang. I built using clang 16.0.6 on Fedora. > And what would you think to merge this patch with previous one, since > this is generated with the changes in previous patch, keeping them both > in same patch looks reasonable to me. That would make sense