From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH 24.03 v2] build: track mandatory rather than optional libs
Date: Fri, 3 Nov 2023 16:52:08 +0000 [thread overview]
Message-ID: <20231103165208.1210182-1-bruce.richardson@intel.com> (raw)
In-Reply-To: <20231103162830.593702-1-bruce.richardson@intel.com>
DPDK now has more optional libraries than mandatory ones, so invert the
list stored in the meson.build file from the optional ones to the
"always_enable" ones. As well as being a shorter list:
* we can remove the loop building up the "always_enable" list
dynamically from the optional list
* it better aligns with the drivers/meson.build file which maintains an
always_enable list.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
V2: List of mandatory libraries is now sorted alphabetically
---
lib/meson.build | 70 +++++++++++++++++--------------------------------
1 file changed, 24 insertions(+), 46 deletions(-)
diff --git a/lib/meson.build b/lib/meson.build
index 6c143ce5a6..8c922d3097 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -75,52 +75,29 @@ if is_ms_compiler
]
endif
-optional_libs = [
- 'bbdev',
- 'bitratestats',
- 'bpf',
- 'cfgfile',
- 'compressdev',
- 'cryptodev',
- 'dispatcher',
- 'distributor',
- 'dmadev',
- 'efd',
- 'eventdev',
- 'gpudev',
- 'graph',
- 'gro',
- 'gso',
- 'ip_frag',
- 'ipsec',
- 'jobstats',
- 'latencystats',
- 'member',
- 'metrics',
- 'mldev',
- 'node',
- 'pcapng',
- 'pdcp',
- 'pdump',
- 'pipeline',
- 'port',
- 'power',
- 'rawdev',
- 'regexdev',
- 'reorder',
- 'sched',
- 'security',
- 'table',
- 'vhost',
+always_enable = [
+ 'acl',
+ 'cmdline',
+ 'eal',
+ 'ethdev',
+ 'fib',
+ 'hash',
+ 'kvargs',
+ 'log',
+ 'lpm',
+ 'mbuf',
+ 'mempool',
+ 'meter',
+ 'net',
+ 'pci',
+ 'rcu',
+ 'rib',
+ 'ring',
+ 'stack',
+ 'telemetry',
+ 'timer',
]
-always_enable = []
-foreach l:libraries
- if not optional_libs.contains(l)
- always_enable += l
- endif
-endforeach
-
enable_deprecated_libs = []
foreach l:run_command(list_dir_globs, get_option('enable_deprecated_libs'),
check: true).stdout().split()
@@ -136,9 +113,10 @@ enable_libs = run_command(list_dir_globs, get_option('enable_libs'), check: true
require_libs = true
if enable_libs.length() == 0
require_libs = false
- enable_libs += optional_libs
+ enable_libs = libraries
+else
+ enable_libs += always_enable
endif
-enable_libs += always_enable
default_cflags = machine_args
default_cflags += ['-DALLOW_EXPERIMENTAL_API']
--
2.39.2
next prev parent reply other threads:[~2023-11-03 16:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 16:28 [PATCH 24.03] " Bruce Richardson
2023-11-03 16:52 ` Bruce Richardson [this message]
2023-11-03 17:31 ` [PATCH 24.03 v2] " Morten Brørup
2023-11-03 18:08 ` Bruce Richardson
2023-11-03 20:19 ` Morten Brørup
2023-11-06 10:28 ` Bruce Richardson
2023-11-06 11:22 ` Morten Brørup
2023-11-06 11:27 ` Bruce Richardson
2023-11-06 11:37 ` Morten Brørup
2023-12-20 14:21 ` [PATCH v3 0/3] Improve optional lib support Bruce Richardson
2023-12-20 14:21 ` [PATCH v3 1/3] build: track mandatory rather than optional libs Bruce Richardson
2023-12-20 14:21 ` [PATCH v3 2/3] build: remove 5 libs from mandatory list Bruce Richardson
2023-12-20 15:18 ` Morten Brørup
2023-12-20 16:05 ` Bruce Richardson
2023-12-20 14:21 ` [PATCH v3 3/3] build: RFC - add support for optional dependencies Bruce Richardson
2023-12-20 15:08 ` Morten Brørup
2023-12-20 15:43 ` Bruce Richardson
2024-10-04 20:59 ` Stephen Hemminger
2024-02-01 9:23 ` [PATCH v3 0/3] Improve optional lib support David Marchand
2024-02-01 9:25 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231103165208.1210182-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).