From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C0A4C432CE;
	Wed,  8 Nov 2023 04:19:22 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 82D0F402DA;
	Wed,  8 Nov 2023 04:19:22 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 3323C402DA
 for <dev@dpdk.org>; Wed,  8 Nov 2023 04:19:21 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 45D1E20B74C0; Tue,  7 Nov 2023 19:19:20 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 45D1E20B74C0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1699413560;
 bh=LlUYq9zEPlZVnHrYICShvhe3vGAlCEGUV8NgWoeZwBg=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=Jv9YdUrDDJ9TyJTPJHv8ECgQyQycZtuAu4qtDkZwG6XseTB3amKP4CkojV3kE0Nib
 X5W7GT2l5zNirhbjEVDbhCe8O100oe7uL3y7sC/kv01PFYxKc1EcDOKy55oW0SQuat
 P0d28ggqo35tQqmBpDmrA8BzsC/8EPhjE3T4N6zA=
Date: Tue, 7 Nov 2023 19:19:20 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com, David Hunt <david.hunt@intel.com>
Subject: Re: [PATCH] eal/x86: fix segfaults in waitpkg power intrinsics
Message-ID: <20231108031920.GA19492@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20231107161900.46058-1-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231107161900.46058-1-bruce.richardson@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Nov 07, 2023 at 04:19:01PM +0000, Bruce Richardson wrote:
> From: David Hunt <david.hunt@intel.com>
> 
> The code was recently enhanced to allow the use of the waitpkg
> intrinsics rather than the raw assembly in the rte_power functions.
> However, the parameters to the intrinsics, while compiling fine, were
> incorrect, and would segfault when run on the appropriate hardware.
> This patch fixes the intrinsic parameters. Tested on a system with
> tpause and umonitor/umwait instructions.
> 
> Fixes: 60943c04f3bc ("eal/x86: use intrinsics for power management")
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>
> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>