From: Kaiwen Deng <kaiwenx.deng@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com,
Kaiwen Deng <kaiwenx.deng@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Zhichao Zeng <zhichaox.zeng@intel.com>
Subject: [PATCH v4] net/iavf: fix mbuf release API selection
Date: Thu, 9 Nov 2023 12:58:36 +0800 [thread overview]
Message-ID: <20231109045836.814164-1-kaiwenx.deng@intel.com> (raw)
In-Reply-To: <20231102044316.541458-1-kaiwenx.deng@intel.com>
When AVX2 is forcibly selected and outer checksum
offload is configured, the basic Tx path will be
selected. Also, the txq mbuf release API is incorrectly
set to iavf_tx_queue_release_mbufs_sse. This causes
coredump.
This commit selects release_txq_mbufs to releasing
txq mbufs when selecting the basic Tx path.
Fixes: 22f1e7608ebc ("net/iavf: fix AVX2 Tx selection")
Cc: stable@dpdk.org
Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
drivers/net/iavf/iavf_rxtx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index 45f638c1d2..f19aa14646 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -4018,11 +4018,9 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
PMD_DRV_LOG(DEBUG, "Using AVX2 Vector Tx (port %d).",
dev->data->port_id);
} else if (check_ret == IAVF_VECTOR_CTX_OFFLOAD_PATH) {
- dev->tx_pkt_burst = iavf_xmit_pkts;
- dev->tx_pkt_prepare = iavf_prep_pkts;
PMD_DRV_LOG(DEBUG,
- "AVX2 does not support outer checksum offload, using Basic Tx (port %d).",
- dev->data->port_id);
+ "AVX2 does not support outer checksum offload.");
+ goto normal;
} else {
dev->tx_pkt_burst = iavf_xmit_pkts_vec_avx2_offload;
dev->tx_pkt_prepare = iavf_prep_pkts;
--
2.34.1
next prev parent reply other threads:[~2023-11-09 5:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 8:54 [PATCH] net/iavf: fix core dump when exiting testpmd Kaiwen Deng
2023-10-31 8:15 ` Zhang, Qi Z
2023-11-01 1:34 ` [PATCH v2] net/iavf: fix coredump " Kaiwen Deng
2023-11-01 7:53 ` Lu, Wenzhuo
2023-11-01 9:32 ` Deng, KaiwenX
2023-11-01 11:00 ` Zhang, Qi Z
2023-11-02 4:43 ` [PATCH v3] net/iavf: fix mbuf release API selection Kaiwen Deng
2023-11-08 9:33 ` Zhang, Qi Z
2023-11-08 12:02 ` Zhang, Qi Z
2023-11-09 1:42 ` Deng, KaiwenX
2023-11-09 4:58 ` Kaiwen Deng [this message]
2023-11-09 12:23 ` [PATCH v4] " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109045836.814164-1-kaiwenx.deng@intel.com \
--to=kaiwenx.deng@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=yidingx.zhou@intel.com \
--cc=zhichaox.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).