[PATCH 0/2] app/test: fix unit test fail on RSS

[PATCH 0/2] app/test: fix unit test fail on RSS

[Jie Hai]

This patch fixes some bugs on test_link_bonding_rssconf.

Jie Hai (2):
  net/null: fix unit test fail on RSS
  app/test: fix uninitialized RSS configuration

 app/test/test_link_bonding_rssconf.c | 2 +-
 drivers/net/null/rte_eth_null.c      | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.30.0

[PATCH 1/2] net/null: fix unit test fail on RSS

[Jie Hai]

The ethdev uses "dev_info->hash_key_size" to check RSS configuration.
So drivers should report the correct info, This patch fixes it.
For more details:
https://bugs.dpdk.org/show_bug.cgi?id=1308

Fixes: bae3cfa520a7 ("ethdev: clarify RSS related fields usage")
Cc: stable@dpdk.org

Signed-off-by: Jie Hai <haijie1@huawei.com>
---
 drivers/net/null/rte_eth_null.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index d742bc415c8c..7c46004f1e33 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -316,6 +316,7 @@ eth_dev_info(struct rte_eth_dev *dev,
 	dev_info->min_rx_bufsize = 0;
 	dev_info->reta_size = internals->reta_size;
 	dev_info->flow_type_rss_offloads = internals->flow_type_rss_offloads;
+	dev_info->hash_key_size = sizeof(internals->rss_key);
 
 	return 0;
 }
-- 
2.30.0

[PATCH 2/2] app/test: fix uninitialized RSS configuration

[Jie Hai]

Since RSS algorithm has been supported, and is checked in ethdev
layer, it is better to initialize "struct rte_eth_rss_conf" before
congiuring RSS. Otherwise, an error will occur.

Fixes: 43b630244e7e ("app/test: add dynamic bonding RSS configuration")
Fixes: bae3cfa520a7 ("ethdev: clarify RSS related fields usage")
Cc: stable@dpdk.org

Signed-off-by: Jie Hai <haijie1@huawei.com>
---
 app/test/test_link_bonding_rssconf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_link_bonding_rssconf.c b/app/test/test_link_bonding_rssconf.c
index cd94e9e5dced..3c9c82433507 100644
--- a/app/test/test_link_bonding_rssconf.c
+++ b/app/test/test_link_bonding_rssconf.c
@@ -324,7 +324,7 @@ test_propagate(void)
 	uint8_t n;
 	struct member_conf *port;
 	uint8_t bond_rss_key[40];
-	struct rte_eth_rss_conf bond_rss_conf;
+	struct rte_eth_rss_conf bond_rss_conf = {0};
 
 	int retval = 0;
 	uint64_t rss_hf = 0;
-- 
2.30.0

Re: [PATCH 0/2] app/test: fix unit test fail on RSS

[Ferruh Yigit]

On 11/9/2023 10:05 AM, Jie Hai wrote:
> This patch fixes some bugs on test_link_bonding_rssconf.
> 
> Jie Hai (2):
>   net/null: fix unit test fail on RSS
>   app/test: fix uninitialized RSS configuration
> 

For series,
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>


Commit logs updated while merging.

Series applied to dpdk-next-net/main, thanks.