From: Jie Hai <haijie1@huawei.com>
To: <dev@dpdk.org>, <songx.jiale@intel.com>,
<zhiminx.huang@intel.com>, <ferruh.yigit@amd.com>,
Chas Williams <chas3@att.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
Tomasz Kulasek <tomaszx.kulasek@intel.com>,
Declan Doherty <declan.doherty@intel.com>,
Chengwen Feng <fengchengwen@huawei.com>,
Huisong Li <lihuisong@huawei.com>
Cc: <liudongdong3@huawei.com>
Subject: [PATCH 2/2] app/test: fix uninitialized RSS configuration
Date: Thu, 9 Nov 2023 18:05:52 +0800 [thread overview]
Message-ID: <20231109100552.1250123-3-haijie1@huawei.com> (raw)
In-Reply-To: <20231109100552.1250123-1-haijie1@huawei.com>
Since RSS algorithm has been supported, and is checked in ethdev
layer, it is better to initialize "struct rte_eth_rss_conf" before
congiuring RSS. Otherwise, an error will occur.
Fixes: 43b630244e7e ("app/test: add dynamic bonding RSS configuration")
Fixes: bae3cfa520a7 ("ethdev: clarify RSS related fields usage")
Cc: stable@dpdk.org
Signed-off-by: Jie Hai <haijie1@huawei.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/app/test/test_link_bonding_rssconf.c b/app/test/test_link_bonding_rssconf.c
index cd94e9e5dced..3c9c82433507 100644
--- a/app/test/test_link_bonding_rssconf.c
+++ b/app/test/test_link_bonding_rssconf.c
@@ -324,7 +324,7 @@ test_propagate(void)
uint8_t n;
struct member_conf *port;
uint8_t bond_rss_key[40];
- struct rte_eth_rss_conf bond_rss_conf;
+ struct rte_eth_rss_conf bond_rss_conf = {0};
int retval = 0;
uint64_t rss_hf = 0;
--
2.30.0
next prev parent reply other threads:[~2023-11-09 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 10:05 [PATCH 0/2] app/test: fix unit test fail on RSS Jie Hai
2023-11-09 10:05 ` [PATCH 1/2] net/null: " Jie Hai
2023-11-09 10:05 ` Jie Hai [this message]
2023-11-09 14:22 ` [PATCH 0/2] app/test: " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109100552.1250123-3-haijie1@huawei.com \
--to=haijie1@huawei.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=humin29@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=songx.jiale@intel.com \
--cc=tomaszx.kulasek@intel.com \
--cc=zhiminx.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).