DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chengwen Feng <fengchengwen@huawei.com>
To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
	Aman Singh <aman.deep.singh@intel.com>,
	Yuying Zhang <yuying.zhang@intel.com>,
	Xuan Ding <xuan.ding@intel.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Wenxuan Wu <wenxuanx.wu@intel.com>,
	Yuan Wang <yuanx.wang@intel.com>
Cc: <dev@dpdk.org>
Subject: [PATCH 14/16] app/testpmd: verify strdup return value
Date: Fri, 10 Nov 2023 06:36:51 +0000	[thread overview]
Message-ID: <20231110063653.5948-15-fengchengwen@huawei.com> (raw)
In-Reply-To: <20231110063653.5948-1-fengchengwen@huawei.com>

Add verify strdup return value logic.

Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 app/test-pmd/cmdline.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 912bf3355c..904c04d466 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3528,6 +3528,8 @@ parse_hdrs_list(const char *str, const char *item_name, unsigned int max_items,
 
 	nb_item = 0;
 	char *str2 = strdup(str);
+	if (str2 == NULL)
+		return nb_item;
 	cur = strtok_r(str2, ",", &tmp);
 	while (cur != NULL) {
 		parsed_items[nb_item] = get_ptype(cur);
-- 
2.17.1


  parent reply	other threads:[~2023-11-10  6:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-10  6:36 [PATCH 00/16] " Chengwen Feng
2023-11-10  6:36 ` [PATCH 01/16] eal: " Chengwen Feng
2023-11-10  6:36 ` [PATCH 02/16] bus/dpaa: " Chengwen Feng
2023-11-10  6:36 ` [PATCH 03/16] bus/fslmc: " Chengwen Feng
2023-11-10  6:36 ` [PATCH 04/16] bus/vdev: " Chengwen Feng
2023-11-10  6:36 ` [PATCH 05/16] dma/idxd: " Chengwen Feng
2023-11-10  6:36 ` [PATCH 06/16] event/cnxk: " Chengwen Feng
2023-11-10  6:36 ` [PATCH 07/16] net/failsafe: fix memory leak when parse args Chengwen Feng
2023-11-10  6:36 ` [PATCH 08/16] net/nfp: verify strdup return value Chengwen Feng
2023-11-10  6:58   ` Chaoyong He
2023-11-10  6:36 ` [PATCH 09/16] app/dumpcap: " Chengwen Feng
2023-11-10  6:36 ` [PATCH 10/16] app/pdump: " Chengwen Feng
2023-11-10  6:36 ` [PATCH 11/16] app/test: " Chengwen Feng
2023-11-10  6:36 ` [PATCH 12/16] app/test-crypto-perf: " Chengwen Feng
2023-11-10  6:36 ` [PATCH 13/16] app/test-dma-perf: " Chengwen Feng
2023-11-10  6:36 ` Chengwen Feng [this message]
2023-11-10  6:36 ` [PATCH 15/16] examples/qos_sched: fix memory leak when parse args Chengwen Feng
2023-11-10  6:36 ` [PATCH 16/16] examples/vhost: verify strdup return value Chengwen Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231110063653.5948-15-fengchengwen@huawei.com \
    --to=fengchengwen@huawei.com \
    --cc=aman.deep.singh@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=thomas@monjalon.net \
    --cc=wenxuanx.wu@intel.com \
    --cc=xuan.ding@intel.com \
    --cc=yuanx.wang@intel.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).