From: Chengwen Feng <fengchengwen@huawei.com>
To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
Gaetan Rivet <grive@u256.net>, Ray Kinsella <mdr@ashroe.eu>,
Xueming Li <xuemingl@nvidia.com>
Cc: <dev@dpdk.org>
Subject: [PATCH 04/16] bus/vdev: verify strdup return value
Date: Fri, 10 Nov 2023 06:36:41 +0000 [thread overview]
Message-ID: <20231110063653.5948-5-fengchengwen@huawei.com> (raw)
In-Reply-To: <20231110063653.5948-1-fengchengwen@huawei.com>
Add verify strdup return value logic.
Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
drivers/bus/vdev/vdev.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 7974b27295..05582f1727 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -247,6 +247,10 @@ alloc_devargs(const char *name, const char *args)
devargs->data = strdup(args);
else
devargs->data = strdup("");
+ if (devargs->data == NULL) {
+ free(devargs);
+ return NULL;
+ }
devargs->args = devargs->data;
ret = strlcpy(devargs->name, name, sizeof(devargs->name));
--
2.17.1
next prev parent reply other threads:[~2023-11-10 6:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 6:36 [PATCH 00/16] " Chengwen Feng
2023-11-10 6:36 ` [PATCH 01/16] eal: " Chengwen Feng
2023-11-10 6:36 ` [PATCH 02/16] bus/dpaa: " Chengwen Feng
2023-11-10 6:36 ` [PATCH 03/16] bus/fslmc: " Chengwen Feng
2023-11-10 6:36 ` Chengwen Feng [this message]
2023-11-10 6:36 ` [PATCH 05/16] dma/idxd: " Chengwen Feng
2023-11-10 6:36 ` [PATCH 06/16] event/cnxk: " Chengwen Feng
2023-11-10 6:36 ` [PATCH 07/16] net/failsafe: fix memory leak when parse args Chengwen Feng
2023-11-10 6:36 ` [PATCH 08/16] net/nfp: verify strdup return value Chengwen Feng
2023-11-10 6:58 ` Chaoyong He
2023-11-10 6:36 ` [PATCH 09/16] app/dumpcap: " Chengwen Feng
2023-11-10 6:36 ` [PATCH 10/16] app/pdump: " Chengwen Feng
2023-11-10 6:36 ` [PATCH 11/16] app/test: " Chengwen Feng
2023-11-10 6:36 ` [PATCH 12/16] app/test-crypto-perf: " Chengwen Feng
2023-11-10 6:36 ` [PATCH 13/16] app/test-dma-perf: " Chengwen Feng
2023-11-10 6:36 ` [PATCH 14/16] app/testpmd: " Chengwen Feng
2023-11-10 6:36 ` [PATCH 15/16] examples/qos_sched: fix memory leak when parse args Chengwen Feng
2023-11-10 6:36 ` [PATCH 16/16] examples/vhost: verify strdup return value Chengwen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110063653.5948-5-fengchengwen@huawei.com \
--to=fengchengwen@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=grive@u256.net \
--cc=mdr@ashroe.eu \
--cc=thomas@monjalon.net \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).