From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org
Subject: Re: BUILD bug hidden in SFC driver.
Date: Sat, 11 Nov 2023 09:29:00 -0800 [thread overview]
Message-ID: <20231111092900.6fee0220@hermes.local> (raw)
In-Reply-To: <20231111085634.5df512bf@hermes.local>
On Sat, 11 Nov 2023 08:56:34 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:
> While examining the use of VLA in DPDK, ran into a bug in sfc driver.
>
> If DPDK is built with -Wvla, then the RTE_BUILD_BUG_ON() macro won't work
> as written. Experimenting with a better more portable version of that macro
> as:
> #define RTE_BUILD_BUG_ON(e) _Static_assert(!(e), #e)
Sending this as RFC also catches another driver with hidden failure.
from ../drivers/event/opdl/opdl_ring.c:10:
./drivers/event/opdl/opdl_ring.c: In function ‘opdl_ring_create’:
./lib/eal/include/rte_common.h:498:44: error: expression in static assertion is not constant
#define RTE_BUILD_BUG_ON(e) _Static_assert(!(e), #e)
^~~~
./drivers/event/opdl/opdl_ring.c:913:2: note: in expansion of macro ‘RTE_BUILD_BUG_ON’
RTE_BUILD_BUG_ON(!rte_is_power_of_2(OPDL_DISCLAIMS_PER_LCORE));
next prev parent reply other threads:[~2023-11-11 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 16:56 Stephen Hemminger
2023-11-11 17:29 ` Stephen Hemminger [this message]
2023-11-13 12:04 ` Ivan Malov
2023-11-13 16:30 ` Stephen Hemminger
2023-11-13 16:28 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231111092900.6fee0220@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).