From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C505043313; Mon, 13 Nov 2023 00:33:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4773F402AB; Mon, 13 Nov 2023 00:33:53 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id AF2C94029A for ; Mon, 13 Nov 2023 00:33:52 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1cc316ccc38so27470805ad.1 for ; Sun, 12 Nov 2023 15:33:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1699832032; x=1700436832; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gdxOkubZz/LG7S/Ph4GkrkV6ONSsMep86ehEwSwbfMw=; b=xfxbmKdVCT//i4K0QuDKlQvWqUljeFghQZGuM17B6JffCRs6O7SU7XSp8EQBLVAjhF XYEViIAudYLVadD7Vw5cNAmVAvfgGdLvO1jnyqlXF6A82RIuudXXQMj/ixgP1MitQ+4h GrboLnwh4iBAgHipGHKQzUHum1wA+7ODXWBIUjZj6YEirUgXXHoDnAjOmQmrPcQRp0dr /XRDrVW8o0EQ6aBqrbQj81f0pbDY1nTgbYiAADw6EfDfzEGB0UCglWE3fIxhNGvpP7fR o5+He8YhakOrdoC0UnwWPziipGCvxzKoI2jyZisJph4QmCBDQJ9vnUKLSfZ9tnDDfJwx z2bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699832032; x=1700436832; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gdxOkubZz/LG7S/Ph4GkrkV6ONSsMep86ehEwSwbfMw=; b=AqvPBqRv4TFyaMrt7wLjq0psGFXeomBV2czSlrlNIGY2MQaYWP7+aFOulyvcs6JWfG 4fY1vVE+1JC/SF+gy0eKjN5Y4ypvJn6iwfrflIh1FvicbxZult75S8gs55UQb3gv610r /2Iu2TH/44ewkSnM0FzhNYSbVe1hHDWOCk12+gnfJNpkDj4RS8JWPc72h2U7eUcdSrjD /aDB8prf8W2GDGrIkEKI8TGZM8erydbDnpoJP01dYRrC/9e3nuimyATLkKOMCKEnD2hU WssT6m0Tf8qm5SQU+dNbDhWBCR33dJsTIscN8Hf6uOZsJOuJu4aSa6ddd9NOT+7TtNml UOtg== X-Gm-Message-State: AOJu0YyB4gwV/7sztSHeqEbQJfflgGl9ZB1aQ0QaKNc85yRRYVz6nafh oXW8LxQeLHVsWkLFcs/Sd/Uyww== X-Google-Smtp-Source: AGHT+IF66ut1L4UVXgWDlPGDv0d9P+6jjQhtADGlPcPbwEKG1j1yPx4TSXNTupJ8TkGskl308U3cmQ== X-Received: by 2002:a05:6a20:3c8a:b0:186:555e:bcc9 with SMTP id b10-20020a056a203c8a00b00186555ebcc9mr1194943pzj.37.1699832031690; Sun, 12 Nov 2023 15:33:51 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id z18-20020a170903019200b001bb97e51ab4sm3012454plg.98.2023.11.12.15.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Nov 2023 15:33:51 -0800 (PST) Date: Sun, 12 Nov 2023 15:33:49 -0800 From: Stephen Hemminger To: Trevor Tao Cc: dev@dpdk.org Subject: Re: [PATCH v3 1/2] examples/l3fwd: relax RSS requirement with option Message-ID: <20231112153349.202150ff@hermes.local> In-Reply-To: <20231112071611.101503-2-taozj888@163.com> References: <20231112071611.101503-1-taozj888@163.com> <20231112071611.101503-2-taozj888@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 12 Nov 2023 07:16:10 +0000 Trevor Tao wrote: > Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS > by default, but some hw and/or virtual interface does not > support the RSS and offload mode presupposed, e.g., some > virtio interfaces in the cloud don't support > RSS and the error msg may like: > > virtio_dev_configure(): RSS support requested but not supported by > the device > Port0 dev_configure = -95 > > So to enable the l3fwd running in that environment, the Rx mode requirement > can be relaxed to reflect the hardware feature reality here, and the l3fwd > can run smoothly then. > > An option named "relax-rx-mode" is added to enable the relax action > here, and it's disabled by default. > > Signed-off-by: Trevor Tao Doesn't need to be an option. The application can just look at the offload flags and quickly determine that if multiple queues are being used than RSS is required. If device doesn't support RSS, then fallback to single queue with a warning.