From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2D714331C; Mon, 13 Nov 2023 17:30:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF72140A7F; Mon, 13 Nov 2023 17:30:46 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 9726F40A7D for ; Mon, 13 Nov 2023 17:30:45 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1cc3542e328so32941315ad.1 for ; Mon, 13 Nov 2023 08:30:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1699893044; x=1700497844; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Duo8f2rUEvCd0eiFYBtW46SFMrWA1wM1NEKie7GlmSY=; b=qsq/Yw+O3BjdcvAmlcB7EP9jqjCRdaR51es9l3baWXlMXflV8F1EmGy3Qv++tzFLEO BH5DacjH4yBZSTje9P6y+k4RYI0HEoZNBuH4u6eXu9b/9n8ljFOt6p+YlEqGdeKyhokq 6cvpDeer8XDYNxw/PQWEDaXqYmvBASdfGZRompVGEAKf2oBI2dQ8MzrI8TUUoSo3aILx xlxH9KUXClrUOBxiKFpIHoklqZjPwNLe3m/CUqxN6dj6O59cx75Yirrzk+8C0t9TSKZK LuXveuGdLv1FAJ+0fsgHGa/ruCb+UAH6T2Fu7B3xHGeQszjK6zNGf6W/HW8ZpQ4Sp7I5 tLQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699893044; x=1700497844; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Duo8f2rUEvCd0eiFYBtW46SFMrWA1wM1NEKie7GlmSY=; b=MfmHsdMODiJhigS0JN5getlsF/LbNW2ZiJiCKGbTB1nJlRk+N5xbrrS1tK1Uu/fsEc DLRwjEyWBhiEn68TfalHHeCOAICJKfERZ2qI9XxTg+N91/x6dkc1YnwDXpEHzx3VUS29 v1wM1lE75cZDGklwVxDeH1SJcNmE1TQDHLFNawOVQcQuL/+VoTTboeaTbuUgK1gc1TNE yBM6/cvnXLmRHz6wSFEvFhW2J+Ui9wNWCiMAJj1pjTrnQZQODrw6iqj2vnWsCSjSzDkd fXW+01c1AUD5GhON5S0+lpUHdzQF4ANz7UZO4+oZ6fujQ7u2KAbi0dgeC4avFazYNLg5 Zhgw== X-Gm-Message-State: AOJu0YxjTJEQCPDL1fRmIG+JPI/rqhMA3TfeIp8eg1GJP4WeEjmecsKL c2crnxDuPTUiE7m7vA0w4O+C0f5/Eii7dOvpsGc= X-Google-Smtp-Source: AGHT+IHc8vOcxNIArcB6qAg1Oc/YoHlEqea5shzevU2RCFJTZBnKxBAUn8dykB12cht1ZdQKRjODug== X-Received: by 2002:a17:903:1252:b0:1cc:2bd9:1b2d with SMTP id u18-20020a170903125200b001cc2bd91b2dmr49913plh.43.1699893044224; Mon, 13 Nov 2023 08:30:44 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id 13-20020a170902c20d00b001a9b29b6759sm4181194pll.183.2023.11.13.08.30.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 08:30:44 -0800 (PST) Date: Mon, 13 Nov 2023 08:30:42 -0800 From: Stephen Hemminger To: Ivan Malov Cc: Andrew Rybchenko , dev@dpdk.org Subject: Re: BUILD bug hidden in SFC driver. Message-ID: <20231113083042.73436883@hermes.local> In-Reply-To: <97a09c56-d946-8c0b-85e2-c2ea4ce25dd6@arknetworks.am> References: <20231111085634.5df512bf@hermes.local> <97a09c56-d946-8c0b-85e2-c2ea4ce25dd6@arknetworks.am> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 13 Nov 2023 16:04:51 +0400 (+04) Ivan Malov wrote: > diff --git a/drivers/net/sfc/sfc_ef100_tx.c b/drivers/net/sfc/sfc_ef100_tx.c > index 1b6374775f..01f37c2616 100644 > --- a/drivers/net/sfc/sfc_ef100_tx.c > +++ b/drivers/net/sfc/sfc_ef100_tx.c > @@ -563,7 +563,7 @@ sfc_ef100_tx_pkt_descs_max(const struct rte_mbuf *m) > * (split into many Tx descriptors). > */ > RTE_BUILD_BUG_ON(SFC_EF100_TX_SEND_DESC_LEN_MAX < > - RTE_MIN((unsigned int)EFX_MAC_PDU_MAX, > + MIN((unsigned int)EFX_MAC_PDU_MAX, > SFC_MBUF_SEG_LEN_MAX)); > } > > with MIN being defined in drivers/common/sfc_efx/efsys.h as > #define MIN(v1, v2) ((v1) < (v2) ? (v1) : (v2)) That should work.