From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 175F243320; Tue, 14 Nov 2023 01:01:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07C2D402DF; Tue, 14 Nov 2023 01:01:08 +0100 (CET) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id 9E640402B3 for ; Tue, 14 Nov 2023 01:00:52 +0100 (CET) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6b2018a11efso5225596b3a.0 for ; Mon, 13 Nov 2023 16:00:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1699920052; x=1700524852; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=PEYpNW7cZMmS5qMma+02dOuf8jYNo4gB3Glsf+aOhkA=; b=IqMPmvaQ75PpEWcthlPocviZlnoVciEB1s7jhIRH+mpCdsujdWSYJNyfkqWI5VGVPx bhmwhuGJpXlNGUqlqIaZPCAKz7CEykg63tfepxoEfihKFuOmNai86aD/3DQSSDNnd8vi niutJoYdo3cFUZpxm/kckt0CjPGEyTn7vzGWZGAywbtswqdB55LeSbKeoLWjkiC/iMBn RaAaWl4Rf1M+jG9IDcM+QhvFkngYVi6HszGfUTKxP3TK4TqSNvwa2NEdVnzsltv/qreJ zL84i7+latbSXO21qHuPCyTR49fDX1l5aEJCImPeTrDjjGjh1mbZB1YUonKU3pg54qrg 6uXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699920052; x=1700524852; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PEYpNW7cZMmS5qMma+02dOuf8jYNo4gB3Glsf+aOhkA=; b=qhicPyU8ow+MkfnAAogUuXToHHZf0bfWETrwLMvpoumlw4RHsbJRwYeT326rU9k1vy RkTQyD7cB/eW7m4dIRe5vjX9TOqjrVrg+0vxKQvR9p6p97x6pXYGbmJhdljXDD4o+YEy 8n+j7dGMH/EVq4PSAMytTZCyc3TbdXHLJvSY6l7mgg9rXygQ2iXaQ7CClrPGEMiUDjBY fNu7jmdi7PvmWcYwSRYkr9tKfBae7Dak54tn4C/OX1aq+WZ5psrtLrkMkke6AQUqgJER ItqnTorzhYhCzg2KRg93zXKOg/y6l568gxr2gntEIRB+BFrnEkIGVVNLHP4YLOpAsvIJ 3JeQ== X-Gm-Message-State: AOJu0Ywpo1UVp24JJ775bsToyp5xlZxTpcs4811Vs7RkS0KJNxar5wDh 8X6x61YL1jSfGV5j/wKxRQWtKg== X-Google-Smtp-Source: AGHT+IEcbKkC2KEf7I6mEa/tNUoNxfMkHYKGA7adPCZwNe9mHNMfQwIfVomZUYba1e9ooQX7BpIZvw== X-Received: by 2002:a05:6a21:78a5:b0:158:17e6:7a6 with SMTP id bf37-20020a056a2178a500b0015817e607a6mr10416594pzc.42.1699920051746; Mon, 13 Nov 2023 16:00:51 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id e7-20020a635447000000b0056b6d1ac949sm4461319pgm.13.2023.11.13.16.00.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 16:00:51 -0800 (PST) Date: Mon, 13 Nov 2023 16:00:49 -0800 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, ivan.malov@oktetlabs.ru, Andrew Rybchenko , Ivan Malov Subject: Re: [PATCH v2 2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON() Message-ID: <20231113160049.0471ddc6@hermes.local> In-Reply-To: <20231113222855.GA26065@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20231111172153.57461-1-stephen@networkplumber.org> <20231113170605.408281-1-stephen@networkplumber.org> <20231113170605.408281-3-stephen@networkplumber.org> <20231113141326.0df15fd6@hermes.local> <20231113222855.GA26065@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 13 Nov 2023 14:28:55 -0800 Tyler Retzlaff wrote: > On Mon, Nov 13, 2023 at 02:13:26PM -0800, Stephen Hemminger wrote: > > On Mon, 13 Nov 2023 09:06:04 -0800 > > Stephen Hemminger wrote: > > > > > The macro RTE_MIN has some hidden assignments to provide type > > > safety which means the statement can not be fully evaluted in > > > first pass of compiler. Replace RTE_MIN() with equivalent macro. > > > > > > This will cause errors from checkpatch about multiple evaluations > > > of same expression in macro but it is ok in this case. > > > > > > Fixes: 4f936666d790 ("net/sfc: support TSO for EF100 native datapath") > > > Cc: ivan.malov@oktetlabs.ru > > > Signed-off-by: Stephen Hemminger > > > > Building with clang finds another issue. > > ../drivers/net/sfc/sfc_rx.c:158:3: error: expected expression > > RTE_BUILD_BUG_ON(RTE_MBUF_F_RX_IP_CKSUM_UNKNOWN != 0); > > yet > > lib/mbuf/rte_mbuf_core.h:#define RTE_MBUF_F_RX_IP_CKSUM_UNKNOWN 0 > > curious. do you have the gcc -E / clang -E preprocessed output for the > expansion? wonder what it looks like. yet another one from clang. ../drivers/net/sfc/sfc_ef10_rx_ev.h:142:4: error: expected expression RTE_BUILD_BUG_ON(ESE_FZ_L4_CLASS_TCP != ESE_DE_L4_CLASS_TCP); drivers/common/sfc_efx/base/efx_regs_ef10.h:#define ESE_FZ_L4_CLASS_TCP 1 drivers/common/sfc_efx/base/efx_regs_ef10.h:#define ESE_DE_L4_CLASS_TCP 1