From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47EA74331D; Mon, 13 Nov 2023 18:56:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3893640E5E; Mon, 13 Nov 2023 18:56:11 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id C99F34026C for ; Mon, 13 Nov 2023 18:55:49 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 2317D20B74C1; Mon, 13 Nov 2023 09:55:49 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2317D20B74C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1699898149; bh=x/ti9VG2PDlxTg88HcNK0JKIYq9DpH3UBj2O2uia0DA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n6AMmTkN8rLpSLOi8+oxzDwVvePohe8+ztazXSfpL1rFG4Px9IRXbOeSm+a+STHm7 2XyamDrVIwxcLaPKu1h+PnyP0IB9RudE09wHqcFvxR0c/0x3fPBRrK21O+kHjWwCKD N5fA5iiKv5tx6wmUjwoh37l1d5Vm+lsy5LfEixXw= Date: Mon, 13 Nov 2023 09:55:49 -0800 From: Tyler Retzlaff To: Stephen Hemminger Cc: dev@dpdk.org, ivan.malov@oktetlabs.ru, Andrew Rybchenko , Ivan Malov Subject: Re: [PATCH v2 2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON() Message-ID: <20231113175549.GB32289@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20231111172153.57461-1-stephen@networkplumber.org> <20231113170605.408281-1-stephen@networkplumber.org> <20231113170605.408281-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113170605.408281-3-stephen@networkplumber.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 13, 2023 at 09:06:04AM -0800, Stephen Hemminger wrote: > The macro RTE_MIN has some hidden assignments to provide type > safety which means the statement can not be fully evaluted in > first pass of compiler. Replace RTE_MIN() with equivalent macro. > > This will cause errors from checkpatch about multiple evaluations > of same expression in macro but it is ok in this case. > > Fixes: 4f936666d790 ("net/sfc: support TSO for EF100 native datapath") > Cc: ivan.malov@oktetlabs.ru > Signed-off-by: Stephen Hemminger > --- Acked-by: Tyler Retzlaff