From: Tomasz Duszynski <tduszynski@marvell.com>
To: <dev@dpdk.org>, Jakub Palider <jpalider@marvell.com>,
Tomasz Duszynski <tduszynski@marvell.com>
Cc: <jerinj@marvell.com>
Subject: [PATCH] raw/cnxk_bphy: switch to dynamic logging
Date: Tue, 14 Nov 2023 09:04:46 +0100 [thread overview]
Message-ID: <20231114080446.3574237-1-tduszynski@marvell.com> (raw)
Dynamically allocated log type is a standard approach among all drivers.
Switch to it.
Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
---
drivers/raw/cnxk_bphy/cnxk_bphy.c | 32 +++++++++++++---------
drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 4 ++-
drivers/raw/cnxk_bphy/cnxk_bphy_cgx.h | 7 +++++
drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 32 ++++++++++------------
4 files changed, 44 insertions(+), 31 deletions(-)
diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c
index 15dbc4c1a6..af3bf97a4d 100644
--- a/drivers/raw/cnxk_bphy/cnxk_bphy.c
+++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c
@@ -6,6 +6,7 @@
#include <dev_driver.h>
#include <rte_eal.h>
#include <rte_lcore.h>
+#include <rte_log.h>
#include <rte_pci.h>
#include <rte_rawdev.h>
#include <rte_rawdev_pmd.h>
@@ -15,6 +16,11 @@
#include "cnxk_bphy_irq.h"
#include "rte_pmd_bphy.h"
+extern int bphy_rawdev_logtype;
+
+#define BPHY_LOG(level, fmt, args...) \
+ rte_log(RTE_LOG_ ## level, bphy_rawdev_logtype, "%s(): " fmt "\n", __func__, ##args)
+
static const struct rte_pci_id pci_bphy_map[] = {
{RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVID_CNXK_BPHY)},
{
@@ -81,7 +87,7 @@ bphy_rawdev_selftest(uint16_t dev_id)
goto err_desc;
if (descs != 1) {
ret = -ENODEV;
- plt_err("Wrong number of descs reported\n");
+ BPHY_LOG(ERR, "Wrong number of descs reported\n");
goto err_desc;
}
@@ -95,7 +101,7 @@ bphy_rawdev_selftest(uint16_t dev_id)
ret = rte_pmd_bphy_intr_init(dev_id);
if (ret) {
- plt_err("intr init failed");
+ BPHY_LOG(ERR, "intr init failed");
return ret;
}
@@ -103,7 +109,7 @@ bphy_rawdev_selftest(uint16_t dev_id)
test = rte_zmalloc("BPHY", max_irq * sizeof(*test), 0);
if (test == NULL) {
- plt_err("intr alloc failed");
+ BPHY_LOG(ERR, "intr alloc failed");
goto err_alloc;
}
@@ -132,7 +138,7 @@ bphy_rawdev_selftest(uint16_t dev_id)
}
if (ret) {
- plt_err("intr register failed at irq %d", i);
+ BPHY_LOG(ERR, "intr register failed at irq %d", i);
goto err_register;
}
}
@@ -142,12 +148,12 @@ bphy_rawdev_selftest(uint16_t dev_id)
for (i = 0; i < max_irq; i++) {
if (!test[i].handled_intr) {
- plt_err("intr %u not handled", i);
+ BPHY_LOG(ERR, "intr %u not handled", i);
ret = -1;
break;
}
if (test[i].handled_data != test[i].test_data) {
- plt_err("intr %u has wrong handler", i);
+ BPHY_LOG(ERR, "intr %u has wrong handler", i);
ret = -1;
break;
}
@@ -251,7 +257,7 @@ cnxk_bphy_irq_enqueue_bufs(struct rte_rawdev *dev,
/* get rid of last response if any */
if (qp->rsp) {
- RTE_LOG(WARNING, PMD, "Previous response got overwritten\n");
+ BPHY_LOG(WARNING, "Previous response got overwritten");
rte_free(qp->rsp);
}
qp->rsp = rsp;
@@ -332,9 +338,8 @@ bphy_rawdev_probe(struct rte_pci_driver *pci_drv,
return 0;
if (!pci_dev->mem_resource[0].addr) {
- plt_err("BARs have invalid values: BAR0 %p\n BAR2 %p",
- pci_dev->mem_resource[0].addr,
- pci_dev->mem_resource[2].addr);
+ BPHY_LOG(ERR, "BARs have invalid values: BAR0 %p\n BAR2 %p",
+ pci_dev->mem_resource[0].addr, pci_dev->mem_resource[2].addr);
return -ENODEV;
}
@@ -346,7 +351,7 @@ bphy_rawdev_probe(struct rte_pci_driver *pci_drv,
bphy_rawdev = rte_rawdev_pmd_allocate(name, sizeof(*bphy_dev),
rte_socket_id());
if (bphy_rawdev == NULL) {
- plt_err("Failed to allocate rawdev");
+ BPHY_LOG(ERR, "Failed to allocate rawdev");
return -ENOMEM;
}
@@ -381,14 +386,14 @@ bphy_rawdev_remove(struct rte_pci_device *pci_dev)
return 0;
if (pci_dev == NULL) {
- plt_err("invalid pci_dev");
+ BPHY_LOG(ERR, "invalid pci_dev");
return -EINVAL;
}
bphy_rawdev_get_name(name, pci_dev);
rawdev = rte_rawdev_pmd_get_named_dev(name);
if (rawdev == NULL) {
- plt_err("invalid device name (%s)", name);
+ BPHY_LOG(ERR, "invalid device name (%s)", name);
return -EINVAL;
}
@@ -410,3 +415,4 @@ static struct rte_pci_driver cnxk_bphy_rawdev_pmd = {
RTE_PMD_REGISTER_PCI(bphy_rawdev_pci_driver, cnxk_bphy_rawdev_pmd);
RTE_PMD_REGISTER_PCI_TABLE(bphy_rawdev_pci_driver, pci_bphy_map);
RTE_PMD_REGISTER_KMOD_DEP(bphy_rawdev_pci_driver, "vfio-pci");
+RTE_LOG_REGISTER_DEFAULT(bphy_rawdev_logtype, WARNING);
diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c
index 2d8466ef91..9eb0da9ed4 100644
--- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c
+++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c
@@ -4,6 +4,7 @@
#include <string.h>
#include <bus_pci_driver.h>
+#include <rte_log.h>
#include <rte_rawdev.h>
#include <rte_rawdev_pmd.h>
@@ -189,7 +190,7 @@ cnxk_bphy_cgx_process_buf(struct cnxk_bphy_cgx *cgx, unsigned int queue,
/* get rid of last response if any */
if (qp->rsp) {
- RTE_LOG(WARNING, PMD, "Previous response got overwritten\n");
+ BPHY_CGX_LOG(WARNING, "Previous response got overwritten");
rte_free(qp->rsp);
}
qp->rsp = rsp;
@@ -379,3 +380,4 @@ static struct rte_pci_driver bphy_cgx_rawdev_pmd = {
RTE_PMD_REGISTER_PCI(cnxk_bphy_cgx_rawdev_pci_driver, bphy_cgx_rawdev_pmd);
RTE_PMD_REGISTER_PCI_TABLE(cnxk_bphy_cgx_rawdev_pci_driver, cnxk_bphy_cgx_map);
RTE_PMD_REGISTER_KMOD_DEP(cnxk_bphy_cgx_rawdev_pci_driver, "vfio-pci");
+RTE_LOG_REGISTER_DEFAULT(bphy_cgx_rawdev_logtype, INFO);
diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.h b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.h
index fb6b31bf4d..fd85a2df33 100644
--- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.h
+++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.h
@@ -5,6 +5,13 @@
#ifndef _CNXK_BPHY_CGX_H_
#define _CNXK_BPHY_CGX_H_
+#include <rte_log.h>
+
+extern int bphy_cgx_rawdev_logtype;
+
+#define BPHY_CGX_LOG(level, fmt, args...) \
+ rte_log(RTE_LOG_ ## level, bphy_cgx_rawdev_logtype, "%s(): " fmt "\n", __func__, ##args)
+
int cnxk_bphy_cgx_dev_selftest(uint16_t dev_id);
#endif /* _CNXK_BPHY_CGX_H_ */
diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c
index a3021b4bb7..5d2a53be31 100644
--- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c
+++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c
@@ -4,7 +4,6 @@
#include <stdint.h>
#include <rte_cycles.h>
-#include <rte_log.h>
#include <rte_malloc.h>
#include <rte_rawdev.h>
@@ -57,62 +56,61 @@ cnxk_bphy_cgx_dev_selftest(uint16_t dev_id)
if (ret)
break;
if (descs != 1) {
- RTE_LOG(ERR, PMD, "Wrong number of descs reported\n");
+ BPHY_CGX_LOG(ERR, "Wrong number of descs reported");
ret = -ENODEV;
break;
}
- RTE_LOG(INFO, PMD, "Testing queue %d\n", i);
+ BPHY_CGX_LOG(INFO, "Testing queue %d", i);
ret = rte_pmd_bphy_cgx_stop_rxtx(dev_id, i);
if (ret) {
- RTE_LOG(ERR, PMD, "Failed to stop rx/tx\n");
+ BPHY_CGX_LOG(ERR, "Failed to stop rx/tx");
break;
}
ret = rte_pmd_bphy_cgx_start_rxtx(dev_id, i);
if (ret) {
- RTE_LOG(ERR, PMD, "Failed to start rx/tx\n");
+ BPHY_CGX_LOG(ERR, "Failed to start rx/tx");
break;
}
ret = rte_pmd_bphy_cgx_set_link_state(dev_id, i, false);
if (ret) {
- RTE_LOG(ERR, PMD, "Failed to set link down\n");
+ BPHY_CGX_LOG(ERR, "Failed to set link down");
break;
}
ret = cnxk_bphy_cgx_link_cond(dev_id, i, 0);
if (ret != 0)
- RTE_LOG(ERR, PMD,
- "Timed out waiting for a link down\n");
+ BPHY_CGX_LOG(ERR, "Timed out waiting for a link down");
ret = rte_pmd_bphy_cgx_set_link_state(dev_id, i, true);
if (ret) {
- RTE_LOG(ERR, PMD, "Failed to set link up\n");
+ BPHY_CGX_LOG(ERR, "Failed to set link up");
break;
}
ret = cnxk_bphy_cgx_link_cond(dev_id, i, 1);
if (ret != 1)
- RTE_LOG(ERR, PMD, "Timed out waiting for a link up\n");
+ BPHY_CGX_LOG(ERR, "Timed out waiting for a link up");
ret = rte_pmd_bphy_cgx_intlbk_enable(dev_id, i);
if (ret) {
- RTE_LOG(ERR, PMD, "Failed to enable internal lbk\n");
+ BPHY_CGX_LOG(ERR, "Failed to enable internal lbk");
break;
}
ret = rte_pmd_bphy_cgx_intlbk_disable(dev_id, i);
if (ret) {
- RTE_LOG(ERR, PMD, "Failed to disable internal lbk\n");
+ BPHY_CGX_LOG(ERR, "Failed to disable internal lbk");
break;
}
ret = rte_pmd_bphy_cgx_ptp_rx_enable(dev_id, i);
/* ptp not available on RPM */
if (ret < 0 && ret != -ENOTSUP) {
- RTE_LOG(ERR, PMD, "Failed to enable ptp\n");
+ BPHY_CGX_LOG(ERR, "Failed to enable ptp");
break;
}
ret = 0;
@@ -120,27 +118,27 @@ cnxk_bphy_cgx_dev_selftest(uint16_t dev_id)
ret = rte_pmd_bphy_cgx_ptp_rx_disable(dev_id, i);
/* ptp not available on RPM */
if (ret < 0 && ret != -ENOTSUP) {
- RTE_LOG(ERR, PMD, "Failed to disable ptp\n");
+ BPHY_CGX_LOG(ERR, "Failed to disable ptp");
break;
}
ret = 0;
ret = rte_pmd_bphy_cgx_get_supported_fec(dev_id, i, &fec);
if (ret) {
- RTE_LOG(ERR, PMD, "Failed to get supported FEC\n");
+ BPHY_CGX_LOG(ERR, "Failed to get supported FEC");
break;
}
ret = rte_pmd_bphy_cgx_set_fec(dev_id, i, fec);
if (ret) {
- RTE_LOG(ERR, PMD, "Failed to set FEC to %d\n", fec);
+ BPHY_CGX_LOG(ERR, "Failed to set FEC to %d", fec);
break;
}
fec = CNXK_BPHY_CGX_ETH_LINK_FEC_NONE;
ret = rte_pmd_bphy_cgx_set_fec(dev_id, i, fec);
if (ret) {
- RTE_LOG(ERR, PMD, "Failed to disable FEC\n");
+ BPHY_CGX_LOG(ERR, "Failed to disable FEC");
break;
}
}
--
2.34.1
next reply other threads:[~2023-11-14 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 8:04 Tomasz Duszynski [this message]
2023-11-15 0:15 ` Stephen Hemminger
2023-11-23 20:36 ` [EXT] " Tomasz Duszynski
2023-11-24 7:56 ` David Marchand
2023-11-27 18:11 ` [PATCH v2] " Tomasz Duszynski
2023-12-06 14:09 ` Jerin Jacob
2024-02-21 1:59 ` Thomas Monjalon
2024-02-21 8:43 ` [EXT] " Tomasz Duszynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114080446.3574237-1-tduszynski@marvell.com \
--to=tduszynski@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jpalider@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).