From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2DDB43330; Wed, 15 Nov 2023 01:18:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE2D0402C7; Wed, 15 Nov 2023 01:18:17 +0100 (CET) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 7DB504027B for ; Wed, 15 Nov 2023 01:18:16 +0100 (CET) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6bf03b98b9bso260856b3a.1 for ; Tue, 14 Nov 2023 16:18:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1700007495; x=1700612295; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FKX0su2cNpXiHywrNpMjsPCLtIxBu+F2vYV5CZic+fU=; b=US7tQ09O4pBUfYp0n/+DV43GTBBmtXjDTrykNi07cIpGrRxeChMq2WAHf4PozdAp8y pt4w43AkGnU7f9eCIOON9A1iO2guSLQnhynPGyJxdI/d0gkwLJtiS+CrnvXON4lStUL4 EcpLFK48sGQVlpnLnocrBtdI9Ak4pJRvCsqterCu3HssZXEwC0mMbw2Vb8T5WZx+U3uq 5KfVQBIli5xu7OMn/Hhx8ONo05QX36drqqD7FSMfTBBzQieg+waOqIn7D2sETadDRcur RpY0Kaz4gYzTWxVnX35sVAlwF1y9TMD65bSXu61vpa1wlolZoaRtevfjNSygXt4OD18/ 7WGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700007495; x=1700612295; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FKX0su2cNpXiHywrNpMjsPCLtIxBu+F2vYV5CZic+fU=; b=B2lm9kJx9qxzPIa7jd2v5AHRX1lfQ3jGYqU4hZFPPO+37QGoLkUU4r0hMeqNW3qgbg gPzGrBnF1v2WU6MI73XHcTSNruDvpJ3HYXiwa/Jgf9Hz0exX+SOdJRaM4b4qDUxGiI3t yM+VThiyIyTJdVRmXqcuc+ggL5g7gaRYM9w6yxsmvpwaH+6rJkqske4yyEyIKqjDfSwY wocr50qW1zzgqclDlDdoKHEZjyZ5TxrbotkWPMQFdXcuJy1z46Uj7fTCt3PASdiQt48p t8Ps2+Gd1EZYFoq6TKKC+oJENTsA4vtydg0GGcleR9ZNJFb2OZF3FkieIopZowr/NrA1 6oBQ== X-Gm-Message-State: AOJu0Yz5qbFDjBU+FTR+9eWy34cX478giQvyoJ1qqImPzjdH4PdvGvEB IN9ZaVnBnNyN68Gg+EEtwlp5hsDN38m1MAwgfO0= X-Google-Smtp-Source: AGHT+IHvza95pYkuSioNZpb7If0Z4wmmD0PkiDchzDrjQcBEJungGCyb8ahAZRL5zRcDWN+j9vIoIg== X-Received: by 2002:a05:6a20:394a:b0:14e:2208:d62f with SMTP id r10-20020a056a20394a00b0014e2208d62fmr6337915pzg.22.1700007495654; Tue, 14 Nov 2023 16:18:15 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id x10-20020a056a00270a00b006c6f668c90bsm1745265pfv.134.2023.11.14.16.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 16:18:15 -0800 (PST) Date: Tue, 14 Nov 2023 16:18:13 -0800 From: Stephen Hemminger To: Dengdui Huang Cc: , , , , Subject: Re: [PATCH 02/43] eal: use rte strerror Message-ID: <20231114161813.29e9b73c@hermes.local> In-Reply-To: <20231114082539.1858594-3-huangdengdui@huawei.com> References: <20231114082539.1858594-1-huangdengdui@huawei.com> <20231114082539.1858594-3-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 14 Nov 2023 16:24:58 +0800 Dengdui Huang wrote: > The function strerror() is insecure in a multi-thread environment. > This patch uses rte_strerror() to replace it. > > Cc: stable@dpdk.org > > Signed-off-by: Dengdui Huang > Acked-by: Chengwen Feng NAK. rte_strerror() is no more thrad safe than strerror() and only is appropriate for rte_errno, ie errors from DPDK. It is not originally designed as strerror() replacement.