From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDA124332E; Tue, 14 Nov 2023 20:19:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDF114064C; Tue, 14 Nov 2023 20:19:33 +0100 (CET) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by mails.dpdk.org (Postfix) with ESMTP id 82578402EE; Tue, 14 Nov 2023 20:19:31 +0100 (CET) Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-507e85ebf50so7953814e87.1; Tue, 14 Nov 2023 11:19:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699989571; x=1700594371; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=S3WKDcKi5rd6jtKZAGbDWoPUDvB6LN0aKQxyngiUWO4=; b=M5xWRNMACEUeMkGA/Sa/DlsKGkJ2mx88XieU9hLcpZKCFZQx9aeNiR7mzoGDLLReQy HUklSdogvLBt3lWC2O6PjFmy1BKce7mIv1JRMnGgr51qTszZbidCZ74WrY4HZnNbnznx 3usD4f+oduCxrp25BOdGfezjwtI4cfzbb6Pz4W45ZeKN/6f301/oUVxbI4jw2kHFu3+I kBOo5em5HkE2UiS44SKxZ+3XsFKQ9ZiZZsfDTdptlIGEcpjg9aTtFCq6sSwXpWXmLEJw TvN0yT6f3CD1VuCGCHv5vyPni+ijWDvq4AXj2LLbz1yynGR0BfUBpGVHwjevWdqvUeC8 o9tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699989571; x=1700594371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S3WKDcKi5rd6jtKZAGbDWoPUDvB6LN0aKQxyngiUWO4=; b=UtQblOEUckROCBdIPm3OBbmsVj6mIx5me3cgGb/GlHUtXYl0yFO4Ui+0ZIMb5kZpUo prNwnqMdbNSHjTa2q304hTkNiPduPyO7WdJfkT77wdlHkKxFEgasK5us24lDcIFE0/6B 6uDwo/i3pgOfnFudRXuU9gb0UOJHTbE+vO1HmdFLKqZ4YuvjTJc/bkeEFILy5IZy038U U+weBmS+TZavhnnBlyiNJH5TgcOiP0Fcr8meZnAL0xH8fMUurCS4tylBrhB1LZ2/fxZh HIHvnz4hdHo9aIkjFO3Dv0HKaxN034TKLiOHRCyguPk8tx3gr+zhw8kgI08fIxvzKL3v lChQ== X-Gm-Message-State: AOJu0YzNFCv+g2tDxe0ZvymqahpB0BkqIdUIQJV7GV+HRzp5cbhQ9VmK w9pSGPzQBnUd489Up2D0p2ORW/kEFUo= X-Google-Smtp-Source: AGHT+IGsH5u64lFfGU9XOh7mtf+4k2qlBGuXEqynflLzHAnOr0WgfeM7kekHkhXdl5U5RE8pLuXmZw== X-Received: by 2002:a05:6512:3b23:b0:509:8e9e:a416 with SMTP id f35-20020a0565123b2300b005098e9ea416mr9330417lfv.47.1699989570744; Tue, 14 Nov 2023 11:19:30 -0800 (PST) Received: from sovereign (broadband-109-173-110-33.ip.moscow.rt.ru. [109.173.110.33]) by smtp.gmail.com with ESMTPSA id a10-20020a056512200a00b0050933bb416csm1407596lfb.74.2023.11.14.11.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 11:19:30 -0800 (PST) Date: Tue, 14 Nov 2023 22:19:28 +0300 From: Dmitry Kozlyuk To: Gregory Etelson Cc: , , , , "Narcisa Ana Maria Vasile" , Dmitry Malloy , Pallavi Kadam Subject: Re: [PATCH] eal/windows: fix memory management macros usage Message-ID: <20231114221928.0ad08931@sovereign> In-Reply-To: <20231114170529.176665-1-getelson@nvidia.com> References: <20231114170529.176665-1-getelson@nvidia.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2023-11-14 19:05 (UTC+0200), Gregory Etelson: > Windows compilation with cross-mingw on Fedora 39 failed > because MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER were > already defined in the compiler environment: > > eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" redefined > /usr/x86_64-w64-mingw32/sys-root/mingw/include/winnt.h:5710: note: > this is the location of the previous definition > > eal_memory.c:78: error: "MEM_RESERVE_PLACEHOLDER" redefined > /usr/x86_64-w64-mingw32/sys-root/mingw/include/winnt.h:5715: note: > this is the location of the previous definition > > The patch masks MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER > macros if they were pre-defined by compiler. > > The patch also masks MEM_COALESCE_PLACEHOLDERS and > MEM_PRESERVE_PLACEHOLDER to prevent similar errors. > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") > > Cc: stable@dpdk.org > Signed-off-by: Gregory Etelson Acked-by: Dmitry Kozlyuk