From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,
stable@dpdk.org, Long Wu <long.wu@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>
Subject: [PATCH 3/5] common/nfp: fix integer handling issues
Date: Wed, 15 Nov 2023 11:23:08 +0800 [thread overview]
Message-ID: <20231115032310.756221-4-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20231115032310.756221-1-chaoyong.he@corigine.com>
CI found integer handling issues, overflow before widen.
Coverity issue: 405351
Fixes: 87f5b35ba4e8 ("common/nfp: move queue logic")
Cc: stable@dpdk.org
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
drivers/common/nfp/nfp_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/common/nfp/nfp_common.c b/drivers/common/nfp/nfp_common.c
index 4c94c9d59a..40e1620c2e 100644
--- a/drivers/common/nfp/nfp_common.c
+++ b/drivers/common/nfp/nfp_common.c
@@ -187,14 +187,14 @@ nfp_enable_queues(struct nfp_hw *hw,
/* Enabling the required TX queues in the device */
enabled_queues = 0;
for (i = 0; i < nb_tx_queues; i++)
- enabled_queues |= (1 << i);
+ enabled_queues |= (1ULL << i);
nn_cfg_writeq(hw, NFP_NET_CFG_TXRS_ENABLE, enabled_queues);
/* Enabling the required RX queues in the device */
enabled_queues = 0;
for (i = 0; i < nb_rx_queues; i++)
- enabled_queues |= (1 << i);
+ enabled_queues |= (1ULL << i);
nn_cfg_writeq(hw, NFP_NET_CFG_RXRS_ENABLE, enabled_queues);
}
--
2.39.1
next prev parent reply other threads:[~2023-11-15 3:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 3:23 [PATCH 0/5] fix coverity issues Chaoyong He
2023-11-15 3:23 ` [PATCH 1/5] vdpa/nfp: fix checking return value Chaoyong He
2023-11-15 3:23 ` [PATCH 2/5] vdpa/nfp: fix integer handling issues Chaoyong He
2023-11-15 3:23 ` Chaoyong He [this message]
2023-11-22 11:50 ` [PATCH 3/5] common/nfp: " Thomas Monjalon
2023-11-23 1:23 ` Chaoyong He
2023-11-23 2:08 ` Thomas Monjalon
2023-11-15 3:23 ` [PATCH 4/5] net/nfp: fix integer shift problem Chaoyong He
2023-11-15 3:23 ` [PATCH 5/5] net/nfp: fix null pointer dereferences Chaoyong He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115032310.756221-4-chaoyong.he@corigine.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).