From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2194D4333A; Wed, 15 Nov 2023 16:08:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C80E402B0; Wed, 15 Nov 2023 16:08:08 +0100 (CET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id D2D144027D for ; Wed, 15 Nov 2023 16:08:06 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6c4eb5fda3cso5381551b3a.2 for ; Wed, 15 Nov 2023 07:08:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1700060886; x=1700665686; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=c1eMgh/gPo6VKwLim3/OiusHO9TBzj/ihwVrrdYOTAY=; b=A1m9D/LEtAqiNS7t/pukezxZv8jkGD9CFrA4gibdBzRgfdDE6i5R06z0+zj2DgW2+o OgDkwbh0zbOmvwcuy3zBW56ZdX59STXoYMixVKmqk1m84b2JmE4bbh5+6qBKRm2YcgFA UniqrV+MhX7J/oQiS/lP9g9/n5gahAQkXHPqMaUT8ePxCFgyxw1HWFTiwOtSaaX1IsyD 3W4l+r3WuWEMmQ7LA9vTs5DF9c3mpmdFOZnH6c3fqcCI7oLl6AN0jKqW4VGvW1KQV8gH Xkna02ALRBJ/Pv9c7dRJkM8wCgz4JuOcVJR/472Zdnu6aHKl/Wzy//3TznI42dt961TE JWaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700060886; x=1700665686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c1eMgh/gPo6VKwLim3/OiusHO9TBzj/ihwVrrdYOTAY=; b=sOmuZ/YQ/Cioz6vR/h+Vp/KtdqE8YqcUVnkGI/CjBFLW1bpxbwqeXHsMOBFKZbxZMP JXZGNYSxh82ic/vxV6SGb4ckyBA7U51ziZs4TqkWjXTCkjBbzDIg5rMrZHEZ2lb+ay1E imAAw805kCv0TELrGu+DgD5EIlD9x+5rvEhvM1z1MwHtdTwf8JGxCCd7Zmz5KPA31u3O tbgezPp/bCENyd0gzeBlpb1DYd7mtBOE00+ilo4H82+WGsrpMZ0pYO0hFYZaq+GaLq/V qdQvm5Ms7/1Nh7MsunL0vAW1viRNd2Jyu0OEIjQRIW8sDu7bUpYFsGSxrYmaH60C1zkG BeFw== X-Gm-Message-State: AOJu0Yyt7aq9ecSnhMr8UijDF2i8TRHVX8TtfhfmOHAf4rWQtOIfjf+a zxL4iDqXz0rCBYDYinTwa/kZhw== X-Google-Smtp-Source: AGHT+IHlq8V0Hrck+x3JNUkbZLLDM3pyncgWzUqeqtv0KFpxd7qco68We05O2Ptn7MC0YOthnET/Ow== X-Received: by 2002:aa7:864e:0:b0:6be:319:446b with SMTP id a14-20020aa7864e000000b006be0319446bmr14245243pfo.21.1700060885984; Wed, 15 Nov 2023 07:08:05 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id x10-20020a056a00270a00b006c6f668c90bsm2904078pfv.134.2023.11.15.07.08.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 07:08:05 -0800 (PST) Date: Wed, 15 Nov 2023 07:08:03 -0800 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: "fengchengwen" , "Tyler Retzlaff" , "Jie Hai" , , Subject: Re: [PATCH 00/21] replace strtok with strtok_r Message-ID: <20231115070803.73846b03@hermes.local> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F027@smartserver.smartshare.dk> References: <20231113104550.2138654-1-haijie1@huawei.com> <20231113170928.GD13153@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20231114173248.GA23774@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20231114173433.GB23774@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20231114174916.GD23774@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <1e636881-c543-b23b-4f75-499b175db058@huawei.com> <98CBD80474FA8B44BF855DF32C47DC35E9F027@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 15 Nov 2023 12:27:37 +0100 Morten Br=C3=B8rup wrote: > > > just a final follow up, i can see that we already have a rte_strerror > > > here to do the replace with reentrant dance. it is probably good to > > > follow the already established pattern for this and have a =20 > > rte_strtok. > >=20 > > +1 for have rte_strtok which could cover different platform. =20 >=20 > +1 to rte_strtok doing the reentrant dance for us. >=20 > If we had such an rte_strtok(), we could also generally disallow the use = of strtok(). Good idea, I like this. Would be good to have a version on Windows as well.