From: Mingjin Ye <mingjinx.ye@intel.com>
To: dev@dpdk.org
Cc: qiming.yang@intel.com, Mingjin Ye <mingjinx.ye@intel.com>,
stable@dpdk.org, Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>
Subject: [PATCH v2] net/iavf: fix error devargs parsing
Date: Wed, 15 Nov 2023 10:13:23 +0000 [thread overview]
Message-ID: <20231115101323.545018-1-mingjinx.ye@intel.com> (raw)
In-Reply-To: <20231113104436.86555-1-mingjinx.ye@intel.com>
This patch fixes unknown parsing results in the absence of
devarg "no-poll-on-link-down" and fixes the devarg variable type.
Fixes: 5b3124a0a6ef ("net/iavf: support no polling when link down")
Fixes: 3e6a5d2d310a ("net/iavf: add devargs to enable VF auto-reset")
Cc: stable@dpdk.org
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
v2: fix devarg variable type.
---
drivers/net/iavf/iavf.h | 4 ++--
drivers/net/iavf/iavf_ethdev.c | 7 +------
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h
index c115f3444e..10868f2c30 100644
--- a/drivers/net/iavf/iavf.h
+++ b/drivers/net/iavf/iavf.h
@@ -307,8 +307,8 @@ struct iavf_devargs {
uint8_t proto_xtr[IAVF_MAX_QUEUE_NUM];
uint16_t quanta_size;
uint32_t watchdog_period;
- uint8_t auto_reset;
- uint16_t no_poll_on_link_down;
+ int auto_reset;
+ int no_poll_on_link_down;
};
struct iavf_security_ctx;
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 0c6ab4ac5a..d1edb0dd5c 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -2294,7 +2294,6 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev)
struct rte_kvargs *kvlist;
int ret;
int watchdog_period = -1;
- uint16_t no_poll_on_link_down;
if (!devargs)
return 0;
@@ -2329,13 +2328,9 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev)
ad->devargs.watchdog_period = watchdog_period;
ret = rte_kvargs_process(kvlist, IAVF_NO_POLL_ON_LINK_DOWN_ARG,
- &parse_u16, &no_poll_on_link_down);
+ &parse_bool, &ad->devargs.no_poll_on_link_down);
if (ret)
goto bail;
- if (no_poll_on_link_down == 0)
- ad->devargs.no_poll_on_link_down = 0;
- else
- ad->devargs.no_poll_on_link_down = 1;
if (ad->devargs.quanta_size != 0 &&
(ad->devargs.quanta_size < 256 || ad->devargs.quanta_size > 4096 ||
--
2.25.1
next prev parent reply other threads:[~2023-11-15 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 10:44 [PATCH] " Mingjin Ye
2023-11-15 8:24 ` Zhang, Qi Z
2023-11-15 10:13 ` Mingjin Ye [this message]
2023-11-16 2:45 ` [PATCH v2] " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115101323.545018-1-mingjinx.ye@intel.com \
--to=mingjinx.ye@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).