From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C6A243355; Fri, 17 Nov 2023 17:22:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29566427E7; Fri, 17 Nov 2023 17:22:14 +0100 (CET) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id 7F6D342686 for <dev@dpdk.org>; Fri, 17 Nov 2023 17:22:13 +0100 (CET) Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5bdc185c449so1656780a12.0 for <dev@dpdk.org>; Fri, 17 Nov 2023 08:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1700238132; x=1700842932; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ixnOKamddRXb1A7/gr4U69zwHaujKTcA5I7UxfK8omM=; b=nHowSswe3PjxbKFUCNDE/apBWsCf57rII2+CZtxnyURpbqzgfUKPuXYq3p3DBePfWI osUz61SPesWM4b7pnCjQNjODqNYF2++NPkENg26p4t8ki2V/aBPVKvl19wqXPRiz9ymI d5rhRRFBMZgnhoefsuMDTT03tnbJ+Wh9uw9c4N4VPmlVSopq6W81b3U7xDewMhW4iQJX Ghgb+JLdzoiGgxnLR2yrq0KG+f60z1MFKjnbWOfRciCSzyhaPt5ht2SkLge4Ebch6219 NrjXoq+D9RnBTrwoSSWRHrXI1HYtLign8GIXaLi6UjdhG1LJcmZmtyqEPGs0iMwgi942 pHig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700238132; x=1700842932; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ixnOKamddRXb1A7/gr4U69zwHaujKTcA5I7UxfK8omM=; b=FWrH0lnErr8fWkL7ejp4BKYj1YWkaI0sUgQkpVuuG4drRUh7zAVKKTcu2GAVt0R/wL hZruFsAlro9Jx9ek9d0E6fzS5cfeh5JG5n76sM0otanBhNxcrvamEg5585N40f38XMQE W2P6axxf11uqLP+1MtFJhpmsO6PPryN3IVgH+vLqYJ/zQGH6MLhGgaQgBMHZunAaUDbw 1PYReusVXGAdsKqkRzMnXbzFvF4bp3Q3UlKhnwLPDdEFp/hKT+OHA89oOWrdagxy+GyF 6HDCHfQ1zbG5cYqTdHIFn0h8T2HpWp8osr/ooVhIK93jvXu5hel9EzfrIa0QtKgBjj/5 7S6A== X-Gm-Message-State: AOJu0Yy6mHEGZwkDZ/HRDAW7ydFGSgG/iVkakmv235d+3DkjVVflT6QS 6V0mKvX7tXdgEOSgy0NW8VbBYA== X-Google-Smtp-Source: AGHT+IFrxMYbXiandjoEnBkmxfT/iAWJeQ/TDHYbZFU9e/PyOhxqbT97eheKfTlrlyUiyKtHusljTg== X-Received: by 2002:a05:6a20:3c91:b0:187:eb60:d6de with SMTP id b17-20020a056a203c9100b00187eb60d6demr4431005pzj.27.1700238132674; Fri, 17 Nov 2023 08:22:12 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id c5-20020a170902d90500b001bc5dc0cd75sm1561202plz.180.2023.11.17.08.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 08:22:12 -0800 (PST) Date: Fri, 17 Nov 2023 08:22:10 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Ferruh Yigit <ferruh.yigit@amd.com> Cc: Kaiwen Deng <kaiwenx.deng@intel.com>, dev@dpdk.org, stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>, Olivier Matz <olivier.matz@6wind.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com> Subject: Re: [PATCH] app/test-pmd: fix L4 checksum with padding data Message-ID: <20231117082210.4d290191@hermes.local> In-Reply-To: <1effba02-7a4c-47bd-8097-a158832c45d7@amd.com> References: <20230804082849.533059-1-kaiwenx.deng@intel.com> <892f0567-e1ee-4283-9726-5db1dd92c2cb@amd.com> <20231116145817.78eb0954@hermes.local> <7a41467c-c863-4ea1-bf7c-9206bf56aa34@amd.com> <20231116192857.0d49ec5b@hermes.local> <1effba02-7a4c-47bd-8097-a158832c45d7@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, 17 Nov 2023 09:29:41 +0000 Ferruh Yigit <ferruh.yigit@amd.com> wrote: > >> I agree using 'l3_len' instead is correct fix. > >> > >> But this requires ABI/API change, > >> plus do we have any reason to keep the padding, discarding it as this > >> patch does is also simpler alternative. > > > > > > Possibly an API version to change the args would work to fix. > > > > rte_ipv4_udptcp_cksum_mbuf() and rte_ipv6_udptcp_cksum_mbuf() are inline > functions, unfortunately we can't version them. > > But those functions already gets IP header as parameter, can't we use IP > header to get the payload size? If so this can be fixed without updating > API. Inlines are easier. Just make a fixed new function and make sure the old one is not used. They shouldn't have been inline in the first place.