From: Stephen Hemminger <stephen@networkplumber.org>
To: Robin Jarry <rjarry@redhat.com>
Cc: dev@dpdk.org, Sunil Kumar Kori <skori@marvell.com>
Subject: Re: [PATCH v2 3/3] usertools/rss: add CNXK well-known key
Date: Mon, 20 Nov 2023 08:41:10 -0800 [thread overview]
Message-ID: <20231120084110.616e2059@hermes.local> (raw)
In-Reply-To: <20231120162256.74399-6-rjarry@redhat.com>
On Mon, 20 Nov 2023 17:22:59 +0100
Robin Jarry <rjarry@redhat.com> wrote:
> diff --git a/usertools/dpdk-rss-flows.py b/usertools/dpdk-rss-flows.py
> index fd225a697f08..be9b3d760c03 100755
> --- a/usertools/dpdk-rss-flows.py
> +++ b/usertools/dpdk-rss-flows.py
> @@ -226,6 +226,23 @@ def reta_size(self, num_queues: int) -> int:
> ),
> reta_size=512,
> ),
> + "cnxk": DriverInfo(
> + key=bytes(
> + (
> + # fmt: off
> + # roc_nix_rss_key_default_fill, see drivers/common/cnxk/roc_nix_rss.c
> + # Marvell's cnxk NICs take 48 bytes keys
> + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,
> + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,
> + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,
> + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,
> + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,
> + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,
> + # fmt: on
> + )
> + ),
> + reta_size=64,
> + ),
> }
Maybe an enhancement in future to expose the default key better.
Having it live in two places means adding new drivers has another
thing to worry about (and not documented).
next prev parent reply other threads:[~2023-11-20 16:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 8:07 [PATCH 1/2] usertools/rss: add driver abstractions Robin Jarry
2023-10-23 8:07 ` [PATCH 2/2] usertools/rss: add --info flag Robin Jarry
2023-11-20 13:28 ` [PATCH 1/2] usertools/rss: add driver abstractions Robin Jarry
2023-11-20 15:13 ` [EXT] " Sunil Kumar Kori
2023-11-20 16:22 ` [PATCH v2 1/3] " Robin Jarry
2023-11-20 16:22 ` [PATCH v2 2/3] usertools/rss: add --info flag Robin Jarry
2023-11-21 6:15 ` [EXT] " Sunil Kumar Kori
2023-11-20 16:22 ` [PATCH v2 3/3] usertools/rss: add CNXK well-known key Robin Jarry
2023-11-20 16:41 ` Stephen Hemminger [this message]
2023-11-21 6:08 ` [EXT] " Sunil Kumar Kori
2023-11-21 6:14 ` [EXT] [PATCH v2 1/3] usertools/rss: add driver abstractions Sunil Kumar Kori
2023-11-22 23:43 ` Thomas Monjalon
2023-11-21 6:11 ` [EXT] [PATCH 1/2] " Sunil Kumar Kori
2023-11-21 16:38 ` Stephen Hemminger
2023-11-21 16:49 ` Thomas Monjalon
2023-11-21 16:51 ` Jerin Jacob
2023-11-21 17:04 ` Stephen Hemminger
2023-11-21 17:21 ` Jerin Jacob
2023-11-21 17:27 ` Stephen Hemminger
2023-11-22 8:28 ` Robin Jarry
2023-11-22 9:37 ` fengchengwen
2023-11-22 23:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120084110.616e2059@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=rjarry@redhat.com \
--cc=skori@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).