From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37C5243391; Tue, 21 Nov 2023 18:27:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F14B842E8E; Tue, 21 Nov 2023 18:27:47 +0100 (CET) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id 9D99D40DCD for ; Tue, 21 Nov 2023 18:27:46 +0100 (CET) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6c396ef9a3dso4919236b3a.1 for ; Tue, 21 Nov 2023 09:27:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1700587666; x=1701192466; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Qa/TsxfiU+Hd25ldnNK119D/udL7DPs24v1gTM8C4vg=; b=YSJCD8C6U2GX1WMOWxfx6zQpzVfzgVlZ2Ob0VMp/iJ3g7VCWfK1HO2LS8cJ1qw+YLJ tl9nP+BiZIhdJ6avsdWFt9RhpCS041rfbEiLneu/xzGB4ZzqedCOmzX4YL+h+DSUwvgP WNnH7rlgfUGI5o/jRorUE1fTc24M30ZUjTC/TxfmdXi6pOMA853eE64cCZeBUMZXDAl2 a6vcOWf3TxZ/kh4SW6QDGVUB8TE8t1CBXlT3X7+kDYCYShgo4AUkxXulNwZRjOCiR7l/ iqBxr0OX6WuPBurqrSKHtzMjmlHOngLEznlkyhUtBkVrVkd2yPmCMR8GfUFBFRrZGyvQ lIkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700587666; x=1701192466; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qa/TsxfiU+Hd25ldnNK119D/udL7DPs24v1gTM8C4vg=; b=v+ENIvvTWGKEBJ/5PUTaGB0c07MV4kuSm8wUNqK9oPSYGUqAZBOByeRBcJSm5klUpq hKFjKubMQVz5zO6wdO53OTc6u221FD/qCDuAMUkIwGWHPrdkXsx0Xxh2KYrrLzkxXZsq hql69zt0eZO9a2JFgvqlsGa9qjJnDuAdsevwVIC8CWqAqxOumUp3BVcTILRaQWskNFgP EP+A+DMJ5lA3J/DEQ2PGaheVqTLKPylpsipsDdPgnOXUqvhaYHGucIeiUe4Ku2Y5yhwp 0kr/PdJzZkZ0qozcrcXOa/kV8IhJzZVszbTBaFucyRTTJPAnICuamcIVjMcIwIGuuXB5 CB7Q== X-Gm-Message-State: AOJu0Yw4lqYIGUutHXEHcSKtkGmifFEYtpdvNvyRS8MZcGNXZdnZNwWa ToGy7U6rRAo9RghcIEOks4TWsQ== X-Google-Smtp-Source: AGHT+IHOFWzxeEquapfEZBvxdEVL4BcRQD6PSD2/HXVjvALrs19kgrWL31B7YN+ol52devyM5P848A== X-Received: by 2002:a05:6a00:3385:b0:6cb:67c3:9c6d with SMTP id cm5-20020a056a00338500b006cb67c39c6dmr8853199pfb.25.1700587665663; Tue, 21 Nov 2023 09:27:45 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y9-20020a62f249000000b006c4d86a259csm8102883pfl.28.2023.11.21.09.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 09:27:45 -0800 (PST) Date: Tue, 21 Nov 2023 09:27:43 -0800 From: Stephen Hemminger To: Jerin Jacob Cc: Robin Jarry , dev@dpdk.org, skori@marvell.com, thomas@monjalon.net Subject: Re: [PATCH 1/2] usertools/rss: add driver abstractions Message-ID: <20231121092743.43f5a6e8@hermes.local> In-Reply-To: References: <20231023080710.240402-3-rjarry@redhat.com> <20231121083855.6ae8e362@hermes.local> <20231121090423.639655f4@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 21 Nov 2023 22:51:19 +0530 Jerin Jacob wrote: > On Tue, Nov 21, 2023 at 10:34=E2=80=AFPM Stephen Hemminger > wrote: > > > > On Tue, 21 Nov 2023 22:21:54 +0530 > > Jerin Jacob wrote: > > =20 > > > > The tool should not need to have driver specific tables like this. > > > > DPDK is already riddled with enough driver specific quirks.. > > > > > > > > That shows a flaw in the rss design, which should have been fixed. = =20 > > > > > > Every NIC's implements standard Toeplitz hash algorithm for RSS hash = generation. > > > Only the initial SEED is different. It is not DPDK property, all the > > > HW like is that as > > > there is no standardization on initial SEED for hash. =20 > > > > The tool should be able to query the default key from driver, or the > > build infrastructure should extract and generate the table. =20 >=20 > IMO, That may be too much of non-productive work to save a couple of > lines(seed array) of duplicate code between c and python. But the tool is incomplete right now, it doesn't cover all the drivers.