From: supeng2087 <supeng2087@aliyun.com>
To: dev@dpdk.org
Cc: supeng <supeng@cmss.chinamobile.com>
Subject: [PATCH] examples/ipsec-secgw: fix cmp_sa_key bug
Date: Wed, 22 Nov 2023 15:58:40 +0800 [thread overview]
Message-ID: <20231122075840.58703-1-supeng2087@aliyun.com> (raw)
From: supeng <supeng@cmss.chinamobile.com>
Inbound direction, sad_lookup function will call cmp_sa_key to compare packet outer ip info with local sa. Local sa src ip should equal packet dst ip, Local sa dst ip should equal src ip.
---
examples/ipsec-secgw/sad.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/examples/ipsec-secgw/sad.h b/examples/ipsec-secgw/sad.h
index 3224b6252c..e1fa8a26f6 100644
--- a/examples/ipsec-secgw/sad.h
+++ b/examples/ipsec-secgw/sad.h
@@ -33,12 +33,12 @@ cmp_sa_key(struct ipsec_sa *sa, int is_v4, struct rte_ipv4_hdr *ipv4,
if ((sa_type == TRANSPORT) ||
/* IPv4 check */
(is_v4 && (sa_type == IP4_TUNNEL) &&
- (sa->src.ip.ip4 == ipv4->src_addr) &&
- (sa->dst.ip.ip4 == ipv4->dst_addr)) ||
+ (sa->src.ip.ip4 == ipv4->dst_addr) &&
+ (sa->dst.ip.ip4 == ipv4->src_addr)) ||
/* IPv6 check */
(!is_v4 && (sa_type == IP6_TUNNEL) &&
- (!memcmp(sa->src.ip.ip6.ip6, ipv6->src_addr, 16)) &&
- (!memcmp(sa->dst.ip.ip6.ip6, ipv6->dst_addr, 16))))
+ (!memcmp(sa->src.ip.ip6.ip6, ipv6->dst_addr, 16)) &&
+ (!memcmp(sa->dst.ip.ip6.ip6, ipv6->src_addr, 16))))
return 1;
return 0;
--
2.34.1
next reply other threads:[~2023-11-22 8:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 7:58 supeng2087 [this message]
2023-11-22 8:22 ` David Marchand
-- strict thread matches above, loose matches on Subject: below --
2023-11-22 7:11 supeng
2023-11-22 6:57 supeng
2023-11-22 6:51 supeng
2023-11-22 6:49 supeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122075840.58703-1-supeng2087@aliyun.com \
--to=supeng2087@aliyun.com \
--cc=dev@dpdk.org \
--cc=supeng@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).