From: Dengdui Huang <huangdengdui@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@amd.com>, <stephen@networkplumber.org>,
<haijie1@huawei.com>, <lihuisong@huawei.com>,
<liuyonglong@huawei.com>, <fengchengwen@huawei.com>
Subject: [PATCH 2/3] net/hns3: fix VF wrong clear reset status
Date: Mon, 27 Nov 2023 21:39:02 +0800 [thread overview]
Message-ID: <20231127133903.1138657-3-huangdengdui@huawei.com> (raw)
In-Reply-To: <20231127133903.1138657-1-huangdengdui@huawei.com>
The function hns3_clear_reset_event is used to clear PF
reset status, The VF shouldn't use it.
This patch fix it.
Fixes: 1eee1ea75c0e ("net/hns3: fix IMP or global reset")
Cc: stable@dpdk.org
Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
---
drivers/net/hns3/hns3_intr.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/hns3/hns3_intr.c b/drivers/net/hns3/hns3_intr.c
index c5a3e3797c..52b5435a23 100644
--- a/drivers/net/hns3/hns3_intr.c
+++ b/drivers/net/hns3/hns3_intr.c
@@ -2749,7 +2749,8 @@ hns3_reset_post(struct hns3_adapter *hns)
/* IMP will wait ready flag before reset */
hns3_notify_reset_ready(hw, false);
hns3_clear_reset_level(hw, &hw->reset.pending);
- hns3_clear_reset_event(hw);
+ if (!hns->is_vf)
+ hns3_clear_reset_event(hw);
__atomic_store_n(&hns->hw.reset.resetting, 0, __ATOMIC_RELAXED);
hw->reset.attempts = 0;
hw->reset.stats.success_cnt++;
@@ -2799,7 +2800,8 @@ hns3_reset_fail_handle(struct hns3_adapter *hns)
struct timeval tv;
hns3_clear_reset_level(hw, &hw->reset.pending);
- hns3_clear_reset_event(hw);
+ if (!hns->is_vf)
+ hns3_clear_reset_event(hw);
if (hns3_reset_err_handle(hns)) {
hw->reset.stage = RESET_STAGE_PREWAIT;
hns3_schedule_reset(hns);
--
2.33.0
next prev parent reply other threads:[~2023-11-27 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 13:39 [PATCH 0/3] fix some bug for hns3 Dengdui Huang
2023-11-27 13:39 ` [PATCH 1/3] net/hns3: fix reset detect be ignored Dengdui Huang
2023-11-27 13:39 ` Dengdui Huang [this message]
2023-11-27 13:39 ` [PATCH 3/3] net/hns3: fix the VF reset interrupted possibly Dengdui Huang
2023-11-27 13:55 ` [PATCH 0/3] fix some bug for hns3 Jie Hai
2023-11-27 18:33 ` Ferruh Yigit
2023-11-28 3:33 ` Jie Hai
2023-11-28 10:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127133903.1138657-3-huangdengdui@huawei.com \
--to=huangdengdui@huawei.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=haijie1@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).