From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id AF36943407;
Wed, 29 Nov 2023 23:12:58 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A15D542E4B;
Wed, 29 Nov 2023 23:12:58 +0100 (CET)
Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com
[209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 4D139402E1
for <dev@dpdk.org>; Wed, 29 Nov 2023 23:12:57 +0100 (CET)
Received: by mail-pj1-f43.google.com with SMTP id
98e67ed59e1d1-2857670af8cso347433a91.0
for <dev@dpdk.org>; Wed, 29 Nov 2023 14:12:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701295976;
x=1701900776; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=SZASTittl3LLMuFKS6tT7wRn7ucnGjAR70r4l2f1Izc=;
b=pJaHQBLElDIcEXP+vm/5ky9BTqIkZlR0r2QSGqpoVQpxCDZvh/YYw0Tat7RnOjpFys
jPUd8Ts4AEV8+emzOxDy0SbRsZim+7rvKa1FjQqoeXZcBR5pBxg3COMtOrEv99/9VWMd
usFWY6E5xAydLc7iny/Z8PcFHXo9vkLzLxyzWelUQVtGCj1Z1oZqTIgrkUBWIt3VSdRY
g3hwtWRFf41jkva2KX1VAxOcRBT5qRmqqe4jY8lbmuVv6xoBcnzlibH99+KmyTSRxhDY
VjgKdTpmUtZ0BPGHfZi+0BEa1ynI6MVcnL4A1kEwAUbPPyJ+jhlD27BJHKooZ8kaeeb8
Xeug==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1701295976; x=1701900776;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=SZASTittl3LLMuFKS6tT7wRn7ucnGjAR70r4l2f1Izc=;
b=Wkh3ZzJ2psNDzQJDr4HbKgCTlAmMRVO4lS8JEhjSg+N/m3BZTm8B8QcpHDT07/XVZc
x9ck4jNTTzAoOdszU/Mh8FG3O/Weim86hRHfFPX1PStG7jCwzufMFcIks5ImNSw0R7Zs
oTs8cj6XAV+O1aaubLJL3IkaC5Z+JxDwbpWhCBLBvrbOKzcUK50zFNBW/IYnRz4TnvGI
ooMYURhABrjfIs+Was7LKIZhrJP7qxCTWmA6VvsVPXzrHkCnWxXoLvEj2qnUCWcDq0wo
3TBQKRHXhSiMkVgTby1HGpc3P5qvRJxkuEyLIU693S88LvfZsQ9vDiFjngZxaE4gDvJW
F+tA==
X-Gm-Message-State: AOJu0YxRSmVSJrdQUbN7EK8hy9Y9DNsGWjIXxGjVdpQaSxb0e7P4/NLs
tOknaWVikrsJafPsEvVn9A2Dig==
X-Google-Smtp-Source: AGHT+IFki9ywd+p6ETkLoDwY23xb4YS3aa3LSz+bKY57mIwlsJM4T+PAx6vh9cwq8Uc+0nWtwfIe7A==
X-Received: by 2002:a17:90b:3ec8:b0:285:936a:86b5 with SMTP id
rm8-20020a17090b3ec800b00285936a86b5mr17430132pjb.20.1701295976459;
Wed, 29 Nov 2023 14:12:56 -0800 (PST)
Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])
by smtp.gmail.com with ESMTPSA id
5-20020a17090a1a4500b0027d05817fcdsm2062728pjl.0.2023.11.29.14.12.56
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 29 Nov 2023 14:12:56 -0800 (PST)
Date: Wed, 29 Nov 2023 14:12:54 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Euan Bourke <euan.bourke@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>, Bruce Richardson
<bruce.richardson@intel.com>
Subject: Re: [PATCH 24.03 v2 1/5] arg_parser: new library for command line
parsing
Message-ID: <20231129141254.75d79417@hermes.local>
In-Reply-To: <20231128140745.595481-2-euan.bourke@intel.com>
References: <20231122164550.3873633-1-euan.bourke@intel.com>
<20231128140745.595481-1-euan.bourke@intel.com>
<20231128140745.595481-2-euan.bourke@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Tue, 28 Nov 2023 14:07:41 +0000
Euan Bourke <euan.bourke@intel.com> wrote:
> +static inline bool
> +get_core_bit(struct core_bits *mask, uint16_t idx)
> +{
> + return !!(mask->bits[idx / 8] & (1 << (idx % 8)));
> +}
> +
You used CHAR_BIT above, why not here?