DPDK patches and discussions
 help / color / mirror / Atom feed
From: Vipin Varghese <vipin.varghese@amd.com>
To: <dev@dpdk.org>, <cristian.dumitrescu@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>
Subject: [PATCH] cfgfile: increase value length
Date: Wed, 6 Dec 2023 16:59:52 +0530	[thread overview]
Message-ID: <20231206112952.1588-1-vipin.varghese@amd.com> (raw)

The default value for CFG_VALUE_LEN is set to 256 characters.
This limits the parsing for longer strings in configuration file.
Setting the default to 2048 characters increases the value array
size in `struct rte_cfgfile_entry`.

Files using cfgfile library are
1. drivers/net/mvpp2/
2. app/test-dma-perf/
3. app/test/
4. examples/qos_sched/

The structure `rte_cfgfile_entry` is not included in DPDK libraries.
Modifying from 256 to 2048 allows `app/test-dma-perf/main.c` helps to
parse longer string as shared in https://bugs.dpdk.org/show_bug.cgi?id=1333

Signed-off-by: Vipin Varghese <vipin.varghese@amd.com>
Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
 lib/cfgfile/rte_cfgfile.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/cfgfile/rte_cfgfile.h b/lib/cfgfile/rte_cfgfile.h
index 232c65c77b..401353c44e 100644
--- a/lib/cfgfile/rte_cfgfile.h
+++ b/lib/cfgfile/rte_cfgfile.h
@@ -24,7 +24,7 @@ extern "C" {
 #endif
 
 #ifndef CFG_VALUE_LEN
-#define CFG_VALUE_LEN 256
+#define CFG_VALUE_LEN 2048
 #endif
 
 /** Configuration file */
-- 
2.34.1


             reply	other threads:[~2023-12-06 11:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06 11:29 Vipin Varghese [this message]
2023-12-06 13:21 ` Bruce Richardson
2023-12-06 13:34   ` Dumitrescu, Cristian
2023-12-06 15:22     ` Varghese, Vipin
2023-12-06 15:50       ` Bruce Richardson
2023-12-06 16:46         ` Varghese, Vipin
2024-02-01 10:32 ` David Marchand
2024-02-01 12:01   ` Varghese, Vipin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231206112952.1588-1-vipin.varghese@amd.com \
    --to=vipin.varghese@amd.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).