From: Stephen Hemminger <stephen@networkplumber.org>
To: Martin Spinler <spinler@cesnet.cz>
Cc: dev@dpdk.org, Rastislav Cernay <cernay@netcope.com>
Subject: Re: [RFT] net/nfb: use dynamic logtype
Date: Thu, 7 Dec 2023 09:32:31 -0800 [thread overview]
Message-ID: <20231207093231.4d793a8f@hermes.local> (raw)
In-Reply-To: <6e4607a0765c6ac5d199e49a88b44a896750b59b.camel@cesnet.cz>
On Thu, 07 Dec 2023 11:37:52 +0100
Martin Spinler <spinler@cesnet.cz> wrote:
> Also, the nfb_rx.h and nfb_tx.h files use the macro NFB_LOG inside,
> please add '#include "nfb_log.h"' into them (then the include in
> nfb_rx.c will be duplicate). Otherwise, all .c sources, which include
> main nfb.h, don't compile.
>
> With these changes, the driver works.
>
> Thank you!
> Martin
I found a few more leftover bits in nfb driver.
Will make a new patchset, and it looks like can build test in a
Redhat VM.
next prev parent reply other threads:[~2023-12-07 17:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 17:51 Stephen Hemminger
2023-12-07 10:37 ` Martin Spinler
2023-12-07 17:32 ` Stephen Hemminger [this message]
2023-12-07 18:56 ` [PATCH 0/3] net/nfb: driver cleanups Stephen Hemminger
2023-12-07 18:56 ` [PATCH 1/3] net/nfb: remove unused device args Stephen Hemminger
2023-12-07 18:56 ` [PATCH 2/3] net/nfb: make device path local to init function Stephen Hemminger
2023-12-07 18:56 ` [PATCH 3/3] net/nfb: use dynamic logtype Stephen Hemminger
2023-12-12 8:49 ` Martin Spinler
2024-01-12 12:16 ` [PATCH 0/3] net/nfb: driver cleanups Ferruh Yigit
2024-01-12 13:50 ` Martin Spinler
2024-02-08 1:02 ` Ferruh Yigit
2024-02-08 12:01 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207093231.4d793a8f@hermes.local \
--to=stephen@networkplumber.org \
--cc=cernay@netcope.com \
--cc=dev@dpdk.org \
--cc=spinler@cesnet.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).