From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68E074369E; Thu, 7 Dec 2023 18:32:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C2A142F04; Thu, 7 Dec 2023 18:32:35 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id EBCA242ECC for ; Thu, 7 Dec 2023 18:32:33 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d0a7b72203so10281165ad.2 for ; Thu, 07 Dec 2023 09:32:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701970353; x=1702575153; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=qoogIx7E6nE5hFgc5zRhDz7Yeb2caF7XfvffOL6Tz/M=; b=KDdPdwlKlW9illCqyThiKptRlqof+PfjYtF2ce6o02Hfdop+FOb5/UhY/+WUvY3nw1 qEqSogbaaghKY9/BRUgTnrKey6t4i66yynWPKkp0wUQQbypeGCZqO/hyASnRStma/sGk STH7xqaEwks0wt5shTm8MzLwVYQ4t79VMtJlnmwCgj6EqHyh7I6Rh/lSuXUot/xVQat5 0ZNEX6CqvWmcRfUtIFyXCj9g+LyNmPbhkbX+hV5tHlV/kTjd518CgSZ99+acP1D2xE0j kXAtK8cBlU0fcJttoVpvdKa63kFmZ86xJu5cu7+UiaKHzNtevvEtrQgkkZzD72/XaCfB xY0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701970353; x=1702575153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qoogIx7E6nE5hFgc5zRhDz7Yeb2caF7XfvffOL6Tz/M=; b=C+iPVjrb6GQKD3IVdiCP6qaB3y2IglHZb0wl3p6JLavfWsXu3GHBGS2FCxT3kaq27K x/i/i1WcQCNeNVECaE9v4GFD1DwDvSDwrjCYf7ZS6vEKxes4iCWWv8TGPCpHZdH/vXY+ zIslc1ktok2qGPXncKNctr/TN3Yp6HA74aJ+wz0k4k0p9SKD+sKqcoSzBoYF+32mCBBW cvbLva6qikLQmdd2zJLBDT/yo/QOrt+oHMDg5NZhw0nuxQHp9NwnlvEU5u7bB8C07z1Z Om1u5km5Mojnl+0IRNZ5+Fdt9sgQNAN7Ck1Tys7n0Mo8vkyjaDRNrdhoTd6c5CFkToou /p+A== X-Gm-Message-State: AOJu0Yz7vGYiUzxgxaTgtIXCAUuRKB1XLKkjs0rHejL5onbE9kZJatse 3SKRm6p5dL0t10aqRAWivKqpYRZQz52AW3U6KJzNLA== X-Google-Smtp-Source: AGHT+IHZyvkOzoi4UFMJ7GbixADNWcCCenuzs8+vPOP8VKcCW57Mn7MQeB/pQCWn7hfoeJFQnfAxhQ== X-Received: by 2002:a17:902:d352:b0:1d0:723f:2350 with SMTP id l18-20020a170902d35200b001d0723f2350mr3105588plk.86.1701970352949; Thu, 07 Dec 2023 09:32:32 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id b23-20020a170902b61700b001d0ca40158dsm64686pls.280.2023.12.07.09.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 09:32:32 -0800 (PST) Date: Thu, 7 Dec 2023 09:32:31 -0800 From: Stephen Hemminger To: Martin Spinler Cc: dev@dpdk.org, Rastislav Cernay Subject: Re: [RFT] net/nfb: use dynamic logtype Message-ID: <20231207093231.4d793a8f@hermes.local> In-Reply-To: <6e4607a0765c6ac5d199e49a88b44a896750b59b.camel@cesnet.cz> References: <20231206175326.116375-1-stephen@networkplumber.org> <6e4607a0765c6ac5d199e49a88b44a896750b59b.camel@cesnet.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 07 Dec 2023 11:37:52 +0100 Martin Spinler wrote: > Also, the nfb_rx.h and nfb_tx.h files use the macro NFB_LOG inside, > please add '#include "nfb_log.h"' into them (then the include in > nfb_rx.c will be duplicate). Otherwise, all .c sources, which include > main nfb.h, don't compile. > > With these changes, the driver works. > > Thank you! > Martin I found a few more leftover bits in nfb driver. Will make a new patchset, and it looks like can build test in a Redhat VM.