DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [PATCH] eal: initialize shared plugins on Windows
Date: Thu, 7 Dec 2023 11:43:43 -0800	[thread overview]
Message-ID: <20231207194343.GB17449@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <1701976851-17275-2-git-send-email-roretzla@linux.microsoft.com>

On Thu, Dec 07, 2023 at 11:20:51AM -0800, Tyler Retzlaff wrote:
> When EAL is built with MSVC it is possible to dynamically load plugins
> on Windows. Hook eal_plugins_init into rte_eal_init if built with MSVC
> and provide code to load plugins on Windows.
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
>  lib/eal/common/eal_common_options.c | 92 ++++++++++++++++++++++++++++++-------
>  lib/eal/windows/eal.c               |  8 ++++
>  2 files changed, 84 insertions(+), 16 deletions(-)
> 
> diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c
> index a6d21f1..3f9a030 100644
> --- a/lib/eal/common/eal_common_options.c
> +++ b/lib/eal/common/eal_common_options.c
> @@ -18,9 +18,7 @@
>  #include <libgen.h>
>  #endif
>  #include <sys/stat.h>
> -#ifndef RTE_EXEC_ENV_WINDOWS
>  #include <dirent.h>
> -#endif
>  
>  #include <rte_string_fns.h>
>  #include <rte_eal.h>
> @@ -74,7 +72,7 @@
>  	{OPT_HELP,              0, NULL, OPT_HELP_NUM             },
>  	{OPT_HUGE_DIR,          1, NULL, OPT_HUGE_DIR_NUM         },
>  	{OPT_HUGE_UNLINK,       2, NULL, OPT_HUGE_UNLINK_NUM      },
> -	{OPT_IOVA_MODE,	        1, NULL, OPT_IOVA_MODE_NUM        },
> +	{OPT_IOVA_MODE,		1, NULL, OPT_IOVA_MODE_NUM        },

accidentally converted 8 spaces to a tab here, will submit a new version
to remove the change from this series (or maintainer can adjust).

thanks

  reply	other threads:[~2023-12-07 19:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07 19:20 Tyler Retzlaff
2023-12-07 19:20 ` Tyler Retzlaff
2023-12-07 19:43   ` Tyler Retzlaff [this message]
2023-12-07 20:26 ` [PATCH v2] " Tyler Retzlaff
2023-12-07 20:26   ` Tyler Retzlaff
2024-01-03  0:05 ` [PATCH v3] " Tyler Retzlaff
2024-01-03  0:05   ` Tyler Retzlaff
2024-01-08 23:38 ` [PATCH v4 0/2] " Tyler Retzlaff
2024-01-08 23:38   ` [PATCH v4 1/2] windows: include winapifamily header for macros Tyler Retzlaff
2024-01-25 21:58     ` Dmitry Kozlyuk
2024-01-08 23:38   ` [PATCH v4 2/2] eal: initialize shared plugins on Windows Tyler Retzlaff
2024-01-25 23:04     ` Dmitry Kozlyuk
2024-01-25 18:44   ` [PATCH v4 0/2] " Tyler Retzlaff
2024-03-12 16:52 ` [PATCH v5 " Tyler Retzlaff
2024-03-12 16:52   ` [PATCH v5 1/2] eal/windows: make dirent.h shim compatible with MinGW Tyler Retzlaff
2024-03-12 16:52   ` [PATCH v5 2/2] eal: initialize shared plugins on Windows Tyler Retzlaff
2024-05-29 14:29     ` Thomas Monjalon
2024-05-29 17:56       ` Tyler Retzlaff
2024-05-30  8:02         ` Thomas Monjalon
2024-03-28 18:18   ` [PATCH v5 0/2] " Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231207194343.GB17449@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=roretzla@linux.microsoft.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=pallavi.kadam@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).