From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69B39436AC; Fri, 8 Dec 2023 18:05:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5916743001; Fri, 8 Dec 2023 18:05:28 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id E248942FF3 for ; Fri, 8 Dec 2023 18:05:26 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1cfabcbda7bso26151035ad.0 for ; Fri, 08 Dec 2023 09:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702055126; x=1702659926; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=EIIiYqTZ6du6EFGPm2uOYCBgO9wI67smsNH/ez+vOtA=; b=WKM0dxy5U7/wPz24H/PaV8GZhyIgzJTOsOKPMPuVEXBvVpkMgrzqARir1CSEfmevlf fYITnS1mk0raOE9XK7iJknE3delcKHdzFDs0391JDPISdXWyz+zg36rMO3koNztVArSz qQ2oqmqguv5nCIFfr42cy5RtwA2jfDpKpPfyef+YfzZ2ftyR3bO0cr/U9juv/uBFItFA 15XsxT9OWY/MwnaVoFzMwY0hhvmk9JbhE942cBeHKGfNXYwWHADenEhd9vEWzJIy5M4Z dqpPw7HKEpds9S4Cou4yC7SPciXp3alEpuFuS0lj0Z4qo5semHsFDjA77td1HyzjdtV2 fPBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702055126; x=1702659926; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EIIiYqTZ6du6EFGPm2uOYCBgO9wI67smsNH/ez+vOtA=; b=RdjiOIJ0phrd2i7VC1U4/VQZ/Z13naN/K0PDdNMRuz8e78h18SlnAxW+MdkHHdlORy V43F/jtVWmrYMOonMAPAw7G2+/s1XibE2D5XuT/uacK3JH4p3oDZHOWRIiO8jnMNu5cg n3rcKCcH1vDRM2BLnXTCuFX2PyhT4lfpTRCkFXwPB2WuClznRv88xuwUq6LGiLRUUhOz EJMtck5g9eUuc5ud9LDuHJ63oEtYDIHekXeL6s1GSNRyX8BMsBsKbNH1zk6gVKebjSmF I/x21myRvfMmeA3WCXMkEZl0ZJLUT/L4isTstCcBlVqZ4RpXSmCYKr+Gy9pqqq+Ii/i/ faLA== X-Gm-Message-State: AOJu0YxC8MmBg5HH4gqtdcg8+r+kpsOqcZsWrZ1tc+YIuXV7pp1Eq20k gcdC3+n40pymrSywrRxCKPnvbg== X-Google-Smtp-Source: AGHT+IEwKhkQHxNLSlv616jEBYNIXyeMF04Un5OWckaOJn72MC5rnmcTm/wRm7vEIIuFanJCc4Uf2Q== X-Received: by 2002:a17:903:2342:b0:1d0:700b:3f78 with SMTP id c2-20020a170903234200b001d0700b3f78mr1606922plh.50.1702055126113; Fri, 08 Dec 2023 09:05:26 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id e3-20020a170902ed8300b001c44dbc92a2sm1601176plj.184.2023.12.08.09.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 09:05:25 -0800 (PST) Date: Fri, 8 Dec 2023 09:05:24 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, mb@smartsharesystems.com, Konstantin Ananyev , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Andrew Rybchenko Subject: Re: [RFC v2 08/14] lib: simplify multilines log messages Message-ID: <20231208090524.01c93717@hermes.local> In-Reply-To: <20231208145950.2184940-9-david.marchand@redhat.com> References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-9-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 8 Dec 2023 15:59:42 +0100 David Marchand wrote: > Those error log messages don't need to span on multiple lines. > > Signed-off-by: David Marchand > --- > lib/acl/tb_mem.c | 2 +- > lib/bpf/bpf_stub.c | 4 ++-- > lib/eal/windows/eal_hugepages.c | 4 ++-- > lib/ethdev/rte_ethdev.c | 14 +++++++------- > 4 files changed, 12 insertions(+), 12 deletions(-) Could you fix these messages to not cross source lines as well? Feel free to shorten the wording as necessary.