From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B60BD436AC; Fri, 8 Dec 2023 18:14:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6487743001; Fri, 8 Dec 2023 18:14:15 +0100 (CET) Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by mails.dpdk.org (Postfix) with ESMTP id 2B00C42FF3 for ; Fri, 8 Dec 2023 18:14:14 +0100 (CET) Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-35d77fb7d94so7786085ab.0 for ; Fri, 08 Dec 2023 09:14:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702055653; x=1702660453; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Z3m/IEnKZ/hcB48ZgeVCvir37av0EIb9qE4JW0O5Tjw=; b=otlu2N6jjvTVkWZH4NCIzh4xC5fwkYFT1x412+hsFyj4MU1RbBl/u4fB/HY6uj7Abx nD/Tu3kfMMhCym8wdTqBkBHWplQ27qr8gvjTWYVPhgc1nb2UOHNb+9atcWkgnh+yjJx0 JAHGdoCnigBeQR3fXDcsubza7MpXg8/VYxEQ1vKXtXckFi6105ha3zUAXQ20hbj51F+t OvdcdJckjaGVojhoF1qCtL7m6wFyJPaL5UW5tuTg/7OiUrzvNMjggIJaOf4u7LY1SJJF lRhZjGJgcZOSAB1hfYIa1eZcVhQ5x5rD+mUy/c23Wvpuqe333Oh41ZwR5ALs/E6dwwJH EuaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702055653; x=1702660453; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z3m/IEnKZ/hcB48ZgeVCvir37av0EIb9qE4JW0O5Tjw=; b=d+mg0hBlMLF0t1eB9X55QJ0c5oPW0hdX8UT8OWWDM5M09FxBU373/P8DMa4rCi85R+ ZlViK2X+UIqARIETuFJd/XdpkDeoT2CyZqp6uRQpcpDarbo34jdHCjivq66247ygMZaw +O3YHDnpvnCjRfvtRS3QKIrh2sDQ3SpDNdQKud1Sawvz/83P6S5ZIIHqESqd9Zg0L5v4 7RX1s+1Ppo0VKk7JLYxFIYIfalMgTZ8nD8odkl9dc1/aYsK+k9za/goXuf7fVup7QKD5 Iwj2J4dxaSH1ZGnwjaDBCt3XQeNXHiD1A2DgG6z3bhwLhdRV2V0Rd3iL4B6WYikzE9z6 +gCg== X-Gm-Message-State: AOJu0Ywbal+mC/euCa9Nbs8dDbsdSXjwLAo9544kykyNbxa2cpL8pGHJ Ib84M8Xu85HbVo0sXtuNsYfq9g== X-Google-Smtp-Source: AGHT+IGK90SgWqMUMKSdArFUregirUgYAfbvkg882oP8XllKCD+L48cMiCpfM8FabWQubvoj8d8G8Q== X-Received: by 2002:a92:c267:0:b0:35d:65fd:184b with SMTP id h7-20020a92c267000000b0035d65fd184bmr593541ild.4.1702055653436; Fri, 08 Dec 2023 09:14:13 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id x1-20020a63cc01000000b005742092c211sm1748434pgf.64.2023.12.08.09.14.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 09:14:13 -0800 (PST) Date: Fri, 8 Dec 2023 09:14:11 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, mb@smartsharesystems.com, Maxime Coquelin , Chenbo Xia Subject: Re: [RFC v2 10/14] vhost: improve log for memory dumping configuration Message-ID: <20231208091411.396b3843@hermes.local> In-Reply-To: <20231208145950.2184940-11-david.marchand@redhat.com> References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-11-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 8 Dec 2023 15:59:44 +0100 David Marchand wrote: > Add the device name as a prefix of logs associated to madvise() calls. > > Signed-off-by: David Marchand > --- > lib/vhost/iotlb.c | 18 +++++++++--------- > lib/vhost/vhost.h | 2 +- > lib/vhost/vhost_user.c | 26 +++++++++++++------------- > 3 files changed, 23 insertions(+), 23 deletions(-) The logging part looks good, but looking at the code, the function mem_set_dump() has some things that should be addressed. Since it is global (but not exported) function the function name may potentially clash when used with static linkage. It should be renamed. Code is duplication of eal_mem_set_dump(). Would be better to have one version. Maybe rte_eal_mem_set_dump()? Acked-by: Stephen Hemminger