From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id AC2A3436AB;
Fri, 8 Dec 2023 16:01:14 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 372DE43001;
Fri, 8 Dec 2023 16:00:33 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by mails.dpdk.org (Postfix) with ESMTP id 2D1B140A70
for <dev@dpdk.org>; Fri, 8 Dec 2023 16:00:31 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1702047630;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=PcYSFHy2gSD+47Vcn7MPGHzKBtyD3M9pbCNzxb1zmdc=;
b=i84kDKucFv/vEU5WZBj7YwOV79kq5RxBUbKRc9x5MBLm8Y4VnLUIV1AqviLaxRd2oXPD8b
ms6qX4d/N2CJzXU5DwgkZmRwaLnaOGl9dyGeII8TyQTjcRvwFPO18Jx7NQli+LY21DKwpI
FgnH+s1sKoKH1bhycsIsOGOgfWb5jlM=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-614-YcwNaVNSPMytmXV7ggNpLg-1; Fri, 08 Dec 2023 10:00:26 -0500
X-MC-Unique: YcwNaVNSPMytmXV7ggNpLg-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com
[10.11.54.7])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F05283B7EB;
Fri, 8 Dec 2023 15:00:25 +0000 (UTC)
Received: from dmarchan.redhat.com (unknown [10.45.224.122])
by smtp.corp.redhat.com (Postfix) with ESMTP id BA1C21C060AF;
Fri, 8 Dec 2023 15:00:23 +0000 (UTC)
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com,
stephen@networkplumber.org, mb@smartsharesystems.com,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Subject: [RFC v2 07/14] bpf: remove log level in internal helper
Date: Fri, 8 Dec 2023 15:59:41 +0100
Message-ID: <20231208145950.2184940-8-david.marchand@redhat.com>
In-Reply-To: <20231208145950.2184940-1-david.marchand@redhat.com>
References: <20231117131824.1977792-1-david.marchand@redhat.com>
<20231208145950.2184940-1-david.marchand@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"; x-default=true
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
There is no other log level than debug, simplify this helper.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/bpf/bpf_validate.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/bpf/bpf_validate.c b/lib/bpf/bpf_validate.c
index 95b9ef99ef..f246b3c5eb 100644
--- a/lib/bpf/bpf_validate.c
+++ b/lib/bpf/bpf_validate.c
@@ -2178,18 +2178,18 @@ restore_eval_state(struct bpf_verifier *bvf, struct inst_node *node)
}
static void
-log_eval_state(const struct bpf_verifier *bvf, const struct ebpf_insn *ins,
- uint32_t pc, int32_t loglvl)
+log_dbg_eval_state(const struct bpf_verifier *bvf, const struct ebpf_insn *ins,
+ uint32_t pc)
{
const struct bpf_eval_state *st;
const struct bpf_reg_val *rv;
- rte_log(loglvl, rte_bpf_logtype, "%s(pc=%u):\n", __func__, pc);
+ RTE_BPF_LOG(DEBUG, "%s(pc=%u):\n", __func__, pc);
st = bvf->evst;
rv = st->rv + ins->dst_reg;
- rte_log(loglvl, rte_bpf_logtype,
+ RTE_BPF_LOG(DEBUG,
"r%u={\n"
"\tv={type=%u, size=%zu},\n"
"\tmask=0x%" PRIx64 ",\n"
@@ -2269,7 +2269,7 @@ evaluate(struct bpf_verifier *bvf)
}
}
- log_eval_state(bvf, ins + idx, idx, RTE_LOG_DEBUG);
+ log_dbg_eval_state(bvf, ins + idx, idx);
bvf->evin = NULL;
}
--
2.43.0