From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0CB5436AD; Fri, 8 Dec 2023 21:49:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A8BA432F4; Fri, 8 Dec 2023 21:49:20 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 665CF432F4; Fri, 8 Dec 2023 21:49:19 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id B2AF820B74C0; Fri, 8 Dec 2023 12:49:18 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B2AF820B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1702068558; bh=6d783QJa+BuGaCH0CidWdscLPYYJlB4L9X7LlwFUbLk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nSduDwdgU+MOs21BkE5+UJP1f9LaxO4inwG7aTNiKPD99PHmVLj/MktWpAEh2X2ff CZW/Hl5GR8BbEiU2Erpa1kQ4kqUykCpXaAQRgGw/fzgc+HIOaRyL8DpuGOHWn7wFpm syBdwri8Ip/sGA0EFwIMmI2S0PGxiXHmMg2yyYec= Date: Fri, 8 Dec 2023 12:49:18 -0800 From: Tyler Retzlaff <roretzla@linux.microsoft.com> To: David Marchand <david.marchand@redhat.com> Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com, stable@dpdk.org, Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Amit Prakash Shukla <amitprakashs@marvell.com>, Jerin Jacob <jerinj@marvell.com>, Naga Harish K S V <s.v.naga.harish.k@intel.com> Subject: Re: [RFC v2 03/14] lib: use dedicated logtypes Message-ID: <20231208204918.GC5699@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-4-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231208145950.2184940-4-david.marchand@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, Dec 08, 2023 at 03:59:37PM +0100, David Marchand wrote: > No printf! > When a dedicated log helper exists, use it. > And no usurpation please: a library should log under its logtype > (see the eventdev rx adapter update for example). > > Note: the RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET macro is renamed for > consistency with the rest of eventdev (private) macros. > > Cc: stable@dpdk.org > > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>