From: Chengwen Feng <fengchengwen@huawei.com>
To: <dev@dpdk.org>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
<stephen@networkplumber.org>
Cc: <tangkunshan@huawei.com>
Subject: [RFC v3 04/12] test/argparse: add verify argument config test
Date: Mon, 11 Dec 2023 09:51:02 +0000 [thread overview]
Message-ID: <20231211095110.18946-5-fengchengwen@huawei.com> (raw)
In-Reply-To: <20231211095110.18946-1-fengchengwen@huawei.com>
This commit adds verify argument config test.
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
app/test/meson.build | 1 +
app/test/test_argparse.c | 327 +++++++++++++++++++++++++++++++++++++++
2 files changed, 328 insertions(+)
create mode 100644 app/test/test_argparse.c
diff --git a/app/test/meson.build b/app/test/meson.build
index dcc93f4a43..864b79d39f 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -27,6 +27,7 @@ source_file_deps = {
# the various test_*.c files
'test_acl.c': ['net', 'acl'],
'test_alarm.c': [],
+ 'test_argparse.c': ['argparse'],
'test_atomic.c': ['hash'],
'test_barrier.c': [],
'test_bitcount.c': [],
diff --git a/app/test/test_argparse.c b/app/test/test_argparse.c
new file mode 100644
index 0000000000..d38ffb5775
--- /dev/null
+++ b/app/test/test_argparse.c
@@ -0,0 +1,327 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 HiSilicon Limited
+ */
+
+#include <stdio.h>
+#include <string.h>
+
+#include <rte_argparse.h>
+
+#include "test.h"
+
+static int default_argc;
+static char *default_argv[1];
+
+/*
+ * Define strdup wrapper.
+ * 1. Mainly to fix compile error "warning: assignment discards 'const'
+ * qualifier from pointer target type [-Wdiscarded-qualifiers]" for
+ * following code:
+ * argv[x] = "100";
+ * 2. Because this is a test, the memory release which allocated by this
+ * wrapper in the subtest is not considered.
+ */
+static char *
+test_strdup(const char *str)
+{
+ char *s = strdup(str);
+ if (s == NULL)
+ exit(-ENOMEM);
+ return s;
+}
+
+static int
+test_argparse_setup(void)
+{
+ default_argc = 1;
+ default_argv[0] = test_strdup("test_argparse");
+ return 0;
+}
+
+static void
+test_argparse_teardown(void)
+{
+ free(default_argv[0]);
+}
+
+static int
+test_argparse_callback(uint32_t index, const char *value, void *opaque)
+{
+ RTE_SET_USED(index);
+ RTE_SET_USED(value);
+ RTE_SET_USED(opaque);
+ return 0;
+}
+
+/* valid templater, must contain at least two args. */
+#define argparse_templater() { \
+ .prog_name = "test_argparse", \
+ .usage = "-a xx -b yy", \
+ .descriptor = NULL, \
+ .epilog = NULL, \
+ .exit_on_error = false, \
+ .callback = test_argparse_callback, \
+ .args = { \
+ { "--abc", "-a", "abc argument", (void *)1, (void *)1, RTE_ARGPARSE_ARG_NO_VALUE | RTE_ARGPARSE_ARG_VALUE_INT }, \
+ { "--xyz", "-x", "xyz argument", (void *)1, (void *)2, RTE_ARGPARSE_ARG_NO_VALUE | RTE_ARGPARSE_ARG_VALUE_INT }, \
+ ARGPARSE_ARG_END(), \
+ }, \
+}
+
+static void
+test_argparse_copy(struct rte_argparse *dst, struct rte_argparse *src)
+{
+ uint32_t i;
+ memcpy(dst, src, sizeof(*src));
+ for (i = 0; /* NULL */; i++) {
+ memcpy(&dst->args[i], &src->args[i], sizeof(src->args[i]));
+ if (src->args[i].name_long == NULL)
+ break;
+ }
+}
+
+static struct rte_argparse *
+test_argparse_init_obj(void)
+{
+ static struct rte_argparse backup = argparse_templater();
+ static struct rte_argparse obj = argparse_templater();
+ test_argparse_copy(&obj, &backup);
+ return &obj;
+}
+
+static int
+test_argparse_invalid_basic_param(void)
+{
+ struct rte_argparse *obj;
+ int ret;
+
+ obj = test_argparse_init_obj();
+ obj->prog_name = NULL;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ obj = test_argparse_init_obj();
+ obj->usage = NULL;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ return TEST_SUCCESS;
+}
+
+static int
+test_argparse_invalid_arg_name(void)
+{
+ struct rte_argparse *obj;
+ int ret;
+
+ obj = test_argparse_init_obj();
+ obj->args[0].name_long = "-ab";
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ obj = test_argparse_init_obj();
+ obj->args[0].name_long = "-abc";
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ obj = test_argparse_init_obj();
+ obj->args[0].name_long = "---c";
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ obj = test_argparse_init_obj();
+ obj->args[0].name_long = "abc";
+ obj->args[0].name_short = "-a";
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ obj = test_argparse_init_obj();
+ obj->args[0].name_short = "a";
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ obj = test_argparse_init_obj();
+ obj->args[0].name_short = "abc";
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ obj = test_argparse_init_obj();
+ obj->args[0].name_short = "ab";
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ return 0;
+}
+
+static int
+test_argparse_invalid_arg_help(void)
+{
+ struct rte_argparse *obj;
+ int ret;
+
+ obj = test_argparse_init_obj();
+ obj->args[0].help = NULL;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ return 0;
+}
+
+static int
+test_argparse_invalid_has_val(void)
+{
+ uint32_t set_mask[] = { 0,
+ RTE_ARGPARSE_ARG_NO_VALUE,
+ RTE_ARGPARSE_ARG_OPTIONAL_VALUE
+ };
+ struct rte_argparse *obj;
+ uint32_t index;
+ int ret;
+
+ obj = test_argparse_init_obj();
+ obj->args[0].flags &= ~0x3u;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ for (index = 0; index < RTE_DIM(set_mask); index++) {
+ obj = test_argparse_init_obj();
+ obj->args[0].name_long = "abc";
+ obj->args[0].name_short = NULL;
+ obj->args[0].flags &= ~0x3u;
+ obj->args[0].flags |= set_mask[index];
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+ }
+
+ return 0;
+}
+
+static int
+test_argparse_invalid_arg_saver(void)
+{
+ struct rte_argparse *obj;
+ int ret;
+
+ /* test saver == NULL with val-type != 0. */
+ obj = test_argparse_init_obj();
+ obj->args[0].val_saver = NULL;
+ obj->args[0].flags = RTE_ARGPARSE_ARG_NO_VALUE | RTE_ARGPARSE_ARG_VALUE_INT;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ /* test saver == NULL with callback is NULL. */
+ obj = test_argparse_init_obj();
+ obj->args[0].val_saver = NULL;
+ obj->args[0].flags = RTE_ARGPARSE_ARG_NO_VALUE;
+ obj->callback = NULL;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ /* test saver != NULL with val-type is zero! */
+ obj = test_argparse_init_obj();
+ obj->args[0].val_saver = (void *)1;
+ obj->args[0].val_set = (void *)1;
+ obj->args[0].flags = RTE_ARGPARSE_ARG_NO_VALUE;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ /* test saver != NULL with val-type is max. */
+ obj = test_argparse_init_obj();
+ obj->args[0].val_saver = (void *)1;
+ obj->args[0].val_set = (void *)1;
+ obj->args[0].flags = RTE_ARGPARSE_ARG_NO_VALUE | RTE_ARGPARSE_ARG_VALUE_MAX;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ /* test saver != NULL with required value, but val-set is not NULL. */
+ obj = test_argparse_init_obj();
+ obj->args[0].val_saver = (void *)1;
+ obj->args[0].val_set = (void *)1;
+ obj->args[0].flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE | RTE_ARGPARSE_ARG_VALUE_INT;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ return 0;
+}
+
+static int
+test_argparse_invalid_arg_flags(void)
+{
+ struct rte_argparse *obj;
+ int ret;
+
+ obj = test_argparse_init_obj();
+ obj->args[0].flags |= ~0x107FFu;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ obj = test_argparse_init_obj();
+ obj->args[0].name_long = "positional";
+ obj->args[0].name_short = NULL;
+ obj->args[0].val_saver = (void *)1;
+ obj->args[0].val_set = (void *)1;
+ obj->args[0].flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE | RTE_ARGPARSE_ARG_VALUE_INT |
+ RTE_ARGPARSE_ARG_SUPPORT_MULTI;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ obj = test_argparse_init_obj();
+ obj->args[0].flags |= RTE_ARGPARSE_ARG_SUPPORT_MULTI;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ obj = test_argparse_init_obj();
+ obj->args[0].val_saver = NULL;
+ obj->args[0].flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE | RTE_ARGPARSE_ARG_SUPPORT_MULTI;
+ obj->callback = NULL;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ return 0;
+}
+
+static int
+test_argparse_invalid_arg_repeat(void)
+{
+ struct rte_argparse *obj;
+ int ret;
+
+ /* test for long name repeat! */
+ obj = test_argparse_init_obj();
+ obj->args[1].name_long = obj->args[0].name_long;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ /* test for short name repeat! */
+ obj = test_argparse_init_obj();
+ obj->args[1].name_short = obj->args[0].name_short;
+ ret = rte_argparse_parse(obj, default_argc, default_argv);
+ TEST_ASSERT(ret == -EINVAL, "Argparse parse expect failed!");
+
+ return 0;
+}
+
+static struct unit_test_suite argparse_test_suite = {
+ .suite_name = "Argparse Unit Test Suite",
+ .setup = test_argparse_setup,
+ .teardown = test_argparse_teardown,
+ .unit_test_cases = {
+ TEST_CASE(test_argparse_invalid_basic_param),
+ TEST_CASE(test_argparse_invalid_arg_name),
+ TEST_CASE(test_argparse_invalid_arg_help),
+ TEST_CASE(test_argparse_invalid_has_val),
+ TEST_CASE(test_argparse_invalid_arg_saver),
+ TEST_CASE(test_argparse_invalid_arg_flags),
+ TEST_CASE(test_argparse_invalid_arg_repeat),
+
+ TEST_CASES_END() /**< NULL terminate unit test array */
+ }
+};
+
+static int
+test_argparse(void)
+{
+ return unit_test_suite_runner(&argparse_test_suite);
+}
+
+REGISTER_FAST_TEST(argparse_autotest, true, true, test_argparse);
--
2.17.1
next prev parent reply other threads:[~2023-12-11 9:55 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 12:26 [24.03 RFC] argparse: add argparse library Chengwen Feng
2023-11-21 16:36 ` Stephen Hemminger
2023-11-22 6:28 ` fengchengwen
2023-12-04 7:50 ` [RFC v2 0/6] " Chengwen Feng
2023-12-04 7:50 ` [RFC v2 1/6] argparse: " Chengwen Feng
2023-12-04 17:10 ` Stephen Hemminger
2023-12-05 1:22 ` fengchengwen
2023-12-04 7:50 ` [RFC v2 2/6] argparse: support verify argument config Chengwen Feng
2023-12-04 7:50 ` [RFC v2 3/6] test/argparse: add verify argument config test Chengwen Feng
2023-12-04 7:50 ` [RFC v2 4/6] argparse: support parse parameters Chengwen Feng
2023-12-04 7:50 ` [RFC v2 5/6] test/argparse: add parse parameters test Chengwen Feng
2023-12-04 7:50 ` [RFC v2 6/6] examples/dma: replace getopt with argparse Chengwen Feng
2023-12-11 9:50 ` [RFC v3 00/12] add argparse library Chengwen Feng
2023-12-11 9:50 ` [RFC v3 01/12] eal: introduce more macro for bit definition Chengwen Feng
2023-12-11 9:51 ` [RFC v3 02/12] argparse: add argparse library Chengwen Feng
2023-12-11 9:51 ` [RFC v3 03/12] argparse: support verify argument config Chengwen Feng
2023-12-11 9:51 ` Chengwen Feng [this message]
2023-12-11 9:51 ` [RFC v3 05/12] argparse: support parse parameters Chengwen Feng
2023-12-11 9:51 ` [RFC v3 06/12] test/argparse: add parse parameters test Chengwen Feng
2023-12-11 9:51 ` [RFC v3 07/12] argparse: provide parsing known type API Chengwen Feng
2023-12-11 9:51 ` [RFC v3 08/12] test/argparse: add parse type test Chengwen Feng
2023-12-11 9:51 ` [RFC v3 09/12] argparse: support parse unsigned base type Chengwen Feng
2023-12-11 9:51 ` [RFC v3 10/12] test/argparse: add parse unsigned base type test Chengwen Feng
2023-12-11 9:51 ` [RFC v3 11/12] argparse: pretty help info Chengwen Feng
2023-12-11 9:51 ` [RFC v3 12/12] examples/dma: replace getopt with argparse Chengwen Feng
2024-01-22 3:57 ` [PATCH 00/12] add argparse library Chengwen Feng
2024-01-22 3:57 ` [PATCH 01/12] eal: introduce more macro for bit definition Chengwen Feng
2024-01-24 13:00 ` Thomas Monjalon
2024-01-22 3:57 ` [PATCH 02/12] argparse: add argparse library Chengwen Feng
2024-01-22 4:54 ` Stephen Hemminger
2024-01-22 6:06 ` fengchengwen
2024-01-24 13:24 ` Thomas Monjalon
2024-01-25 3:44 ` fengchengwen
2024-01-22 3:57 ` [PATCH 03/12] argparse: support verify argument config Chengwen Feng
2024-01-22 3:57 ` [PATCH 04/12] test/argparse: add verify argument config test Chengwen Feng
2024-01-24 13:01 ` Thomas Monjalon
2024-01-22 3:57 ` [PATCH 05/12] argparse: support parse parameters Chengwen Feng
2024-01-22 3:57 ` [PATCH 06/12] test/argparse: add parse parameters test Chengwen Feng
2024-01-22 3:57 ` [PATCH 07/12] argparse: provide parsing known type API Chengwen Feng
2024-01-22 3:57 ` [PATCH 08/12] test/argparse: add parse type test Chengwen Feng
2024-01-22 3:57 ` [PATCH 09/12] argparse: support parse unsigned base type Chengwen Feng
2024-01-22 3:58 ` [PATCH 10/12] test/argparse: add parse unsigned base type test Chengwen Feng
2024-01-22 3:58 ` [PATCH 11/12] argparse: pretty help info Chengwen Feng
2024-01-22 3:58 ` [PATCH 12/12] examples/dma: replace getopt with argparse Chengwen Feng
2024-01-24 13:26 ` Thomas Monjalon
2024-01-24 15:54 ` [24.03 RFC] argparse: add argparse library Stephen Hemminger
2024-01-25 6:31 ` fengchengwen
2024-01-26 16:38 ` Stephen Hemminger
2024-01-25 11:52 ` [PATCH v2 0/8] " Chengwen Feng
2024-01-25 11:52 ` [PATCH v2 1/8] eal: introduce more macro for bit definition Chengwen Feng
2024-01-25 11:52 ` [PATCH v2 2/8] argparse: add argparse library Chengwen Feng
2024-01-25 11:52 ` [PATCH v2 3/8] argparse: support verify argument config Chengwen Feng
2024-01-25 11:52 ` [PATCH v2 4/8] argparse: support parse parameters Chengwen Feng
2024-01-25 11:52 ` [PATCH v2 5/8] argparse: provide parsing known type API Chengwen Feng
2024-01-25 11:52 ` [PATCH v2 6/8] argparse: support parse unsigned base type Chengwen Feng
2024-01-25 11:52 ` [PATCH v2 7/8] argparse: pretty help info Chengwen Feng
2024-01-25 11:52 ` [PATCH v2 8/8] examples/dma: replace getopt with argparse Chengwen Feng
2024-01-26 6:10 ` [PATCH v3 0/8] add argparse library Chengwen Feng
2024-01-26 6:10 ` [PATCH v3 1/8] eal: introduce more macro for bit definition Chengwen Feng
2024-01-26 6:10 ` [PATCH v3 2/8] argparse: add argparse library Chengwen Feng
2024-01-26 6:10 ` [PATCH v3 3/8] argparse: support verify argument config Chengwen Feng
2024-01-26 6:10 ` [PATCH v3 4/8] argparse: support parse parameters Chengwen Feng
2024-01-26 6:10 ` [PATCH v3 5/8] argparse: provide parsing known type API Chengwen Feng
2024-01-26 6:10 ` [PATCH v3 6/8] argparse: support parse unsigned base type Chengwen Feng
2024-01-26 6:10 ` [PATCH v3 7/8] argparse: pretty help info Chengwen Feng
2024-01-26 6:10 ` [PATCH v3 8/8] examples/dma: replace getopt with argparse Chengwen Feng
2024-02-14 16:53 ` [PATCH v3 0/8] add argparse library Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211095110.18946-5-fengchengwen@huawei.com \
--to=fengchengwen@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stephen@networkplumber.org \
--cc=tangkunshan@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).