From: Stephen Hemminger <stephen@networkplumber.org>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 0/3] replace use of EAL logtype
Date: Mon, 11 Dec 2023 12:15:47 -0800 [thread overview]
Message-ID: <20231211121547.0bbe500b@hermes.local> (raw)
In-Reply-To: <20231211191931.GB16826@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On Mon, 11 Dec 2023 11:19:31 -0800
Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
> On Mon, Dec 11, 2023 at 09:23:22AM -0800, Stephen Hemminger wrote:
> > There are some places EAL logtype is being used in testpmd
> > and examples where it should not be. Lets reserve EAL
> > logtype to only be used by DPDK internals.
> >
> > Stephen Hemminger (3):
> > testpmd: replace EAL logtype with fprintf
> > examples/l2fwd-keepalive: don't use EAL logtype
> > examples/vm_power_manager: do not use EAL logtype
> >
> > app/test-pmd/testpmd.c | 33 +++++++++++---------------------
> > examples/l2fwd-keepalive/shm.c | 21 +++++++-------------
> > examples/vm_power_manager/main.c | 11 ++++-------
>
> are the log types under ALLOW_INTERNAL_API? if not should they be? and
> if they are should examples be defining ALLOW_INTERNAL_API?
>
> just curious.
>
No they never were under ALLOW_INTERNAL_API.
They should have been, but a little late now to change.
next prev parent reply other threads:[~2023-12-11 20:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 17:23 Stephen Hemminger
2023-12-11 17:23 ` [PATCH 1/3] testpmd: replace EAL logtype with fprintf Stephen Hemminger
2023-12-12 11:51 ` lihuisong (C)
2023-12-11 17:23 ` [PATCH 2/3] examples/l2fwd-keepalive: don't use EAL logtype Stephen Hemminger
2023-12-12 11:53 ` lihuisong (C)
2023-12-11 17:23 ` [PATCH 3/3] examples/vm_power_manager: do not " Stephen Hemminger
2023-12-12 11:24 ` Hunt, David
2023-12-12 11:53 ` lihuisong (C)
2023-12-11 19:19 ` [PATCH 0/3] replace use of " Tyler Retzlaff
2023-12-11 20:15 ` Stephen Hemminger [this message]
2023-12-12 8:01 ` David Marchand
2024-02-16 3:36 ` [PATCH v2 0/3] replace use of EAL logtype in applications Stephen Hemminger
2024-02-16 3:36 ` [PATCH v2 1/3] examples/l2fwd-keepalive: don't use EAL logtype Stephen Hemminger
2024-02-16 8:04 ` Morten Brørup
2024-02-16 3:36 ` [PATCH v2 2/3] examples/vm_power_manager: do not " Stephen Hemminger
2024-02-16 3:36 ` [PATCH v2 3/3] testpmd: replace EAL logtype TESTPMD_LOG Stephen Hemminger
2024-03-08 13:35 ` Singh, Aman Deep
2024-03-08 16:26 ` Stephen Hemminger
2024-02-18 3:16 ` [PATCH v2 0/3] replace use of EAL logtype in applications fengchengwen
2024-03-08 18:10 ` [PATCH v3 " Stephen Hemminger
2024-03-08 18:10 ` [PATCH v3 1/3] examples/l2fwd-keepalive: don't use EAL logtype Stephen Hemminger
2024-03-08 18:10 ` [PATCH v3 2/3] examples/vm_power_manager: do not " Stephen Hemminger
2024-03-08 18:10 ` [PATCH v3 3/3] testpmd: replace EAL logtype TESTPMD_LOG Stephen Hemminger
2024-03-08 22:33 ` [PATCH v4 0/3] replace use of EAL logtype in applications Stephen Hemminger
2024-03-08 22:33 ` [PATCH v4 1/3] examples/l2fwd-keepalive: don't use EAL logtype Stephen Hemminger
2024-03-08 22:33 ` [PATCH v4 2/3] examples/vm_power_manager: do not " Stephen Hemminger
2024-03-08 22:33 ` [PATCH v4 3/3] testpmd: replace EAL logtype TESTPMD_LOG Stephen Hemminger
2024-03-11 10:24 ` Singh, Aman Deep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211121547.0bbe500b@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).