From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id E5F8E436E3;
Wed, 13 Dec 2023 17:42:37 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 91DF442FF7;
Wed, 13 Dec 2023 17:40:33 +0100 (CET)
Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com
[209.85.214.179])
by mails.dpdk.org (Postfix) with ESMTP id 8BDA242F93
for <dev@dpdk.org>; Wed, 13 Dec 2023 17:40:22 +0100 (CET)
Received: by mail-pl1-f179.google.com with SMTP id
d9443c01a7336-1d06819a9cbso41707055ad.1
for <dev@dpdk.org>; Wed, 13 Dec 2023 08:40:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485622;
x=1703090422; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=IfEBZNx5o1grAD5H8WxbgdgKmhV0o98XWrLO5UjgMBA=;
b=UXZZZhmZi59FKolswzK7zv15sIexBCTjOmcL5lrxmnj/oyxAMjoUDKKpv3lKWX58yd
WaF0zrAGycTUgq/MlqBUJyMA5zuEIWPmxgh0rDa+wCauFUoFISV7mbeBso4h1yA9qzba
QrMSIGUbPY7FgfMJ2uCLtHUSvCuD0rztRH5/oIE3/N8bLvuX+mRHUzjIzcqXHiElhHcl
u0JOeItNc3fG9Z4l4rMSt5KNX3/CSt5KIJ53hCFjtx0G43F1gfYWL2gDBqIIFjYK+nG7
CNLLwMnBu1QMGv+X7VrhR5xdqRroN9/izDrHjlklMMEL/wTKtTmYjncS9dyAb0bqIsW+
W4pQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1702485622; x=1703090422;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=IfEBZNx5o1grAD5H8WxbgdgKmhV0o98XWrLO5UjgMBA=;
b=Z4K/GdA+IjMJg2p90iGea52Wl2iNQFni1AO1WVAIQ8lFB+zwdIK1GRcv/F8QDWLdVB
ewZTszJ0xPdlltek+gYEuBzzGL/fA0uQUdkdq/mUkrcLYxHr9fp5yF8Enze8Lbsa4edF
VKxC3vBArImVvUCogNdGgSCZYBFyyPb6wDeupQcVXUXCSIy5aCg1W2Z4gQ0Sab8C7Vnh
VqRb8RkrF5QMzX2BQ8GnuTLRDgrdbHUHqukHBvE68JP4uzHznMlz6IckOGIXDAF9VQ8f
/iW4DejwKzmlWGhkaTMfFRXMnC5i+lWAMkVmPLM6UYGKAhVpuQf/xxaMJ8pnJM5Y76GD
ALfQ==
X-Gm-Message-State: AOJu0Yx4vmz9VAjPQes8Kx5FmHjCiJaPgfUGEzCRt7FEhiB4ZJxaE/Zx
vR8gApVJx5XvxHk8YvalYYC2RYfuVrzscnsuF5o=
X-Google-Smtp-Source: AGHT+IGifu8FlMR4k+Ptfv1u9v6sOWsKDB92dF4e4Uffuh+OZIqsZhyxWCcpc7bQvUWMW7Lo3FTeGg==
X-Received: by 2002:a17:902:f690:b0:1d0:a663:20fe with SMTP id
l16-20020a170902f69000b001d0a66320femr4217823plg.80.1702485621810;
Wed, 13 Dec 2023 08:40:21 -0800 (PST)
Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])
by smtp.gmail.com with ESMTPSA id
4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.21
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 13 Dec 2023 08:40:21 -0800 (PST)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Jerin Jacob <jerinj@marvell.com>
Subject: [PATCH v3 33/37] event/skeleton: replace logtype PMD with dynamic type
Date: Wed, 13 Dec 2023 08:36:07 -0800
Message-ID: <20231213163820.894987-34-stephen@networkplumber.org>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20231213163820.894987-1-stephen@networkplumber.org>
References: <20231213014408.612051-1-stephen@networkplumber.org>
<20231213163820.894987-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
The skeleton is supposed to match current best practices.
Change it to use dynamic logtype.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/event/skeleton/skeleton_eventdev.c | 3 ++-
drivers/event/skeleton/skeleton_eventdev.h | 8 ++++++--
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c
index 7df032b7daa1..df50d2e4e4ff 100644
--- a/drivers/event/skeleton/skeleton_eventdev.c
+++ b/drivers/event/skeleton/skeleton_eventdev.c
@@ -457,7 +457,7 @@ skeleton_eventdev_probe(struct rte_vdev_device *vdev)
const char *name;
name = rte_vdev_device_name(vdev);
- RTE_LOG(INFO, PMD, "Initializing %s on NUMA node %d\n", name,
+ PMD_DRV_LOG(INFO, "Initializing %s on NUMA node %d\n", name,
rte_socket_id());
return skeleton_eventdev_create(name, rte_socket_id(), vdev);
}
@@ -479,3 +479,4 @@ static struct rte_vdev_driver vdev_eventdev_skeleton_pmd = {
};
RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_SKELETON_PMD, vdev_eventdev_skeleton_pmd);
+RTE_LOG_REGISTER_DEFAULT(skeleton_eventdev_logtype, INFO);
diff --git a/drivers/event/skeleton/skeleton_eventdev.h b/drivers/event/skeleton/skeleton_eventdev.h
index 9193f45f4782..9c1ed4ec5755 100644
--- a/drivers/event/skeleton/skeleton_eventdev.h
+++ b/drivers/event/skeleton/skeleton_eventdev.h
@@ -8,9 +8,12 @@
#include <eventdev_pmd_pci.h>
#include <eventdev_pmd_vdev.h>
+extern int skeleton_eventdev_logtype;
+
#ifdef RTE_LIBRTE_PMD_SKELETON_EVENTDEV_DEBUG
#define PMD_DRV_LOG(level, fmt, args...) \
- RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
+ rte_log(RTE_LOG_ ## level, skeleton_eventdev_logtype, \
+ "%s(): " fmt "\n", __func__, ## args)
#define PMD_DRV_FUNC_TRACE() PMD_DRV_LOG(DEBUG, ">>")
#else
#define PMD_DRV_LOG(level, fmt, args...) do { } while (0)
@@ -18,7 +21,8 @@
#endif
#define PMD_DRV_ERR(fmt, args...) \
- RTE_LOG(ERR, PMD, "%s(): " fmt "\n", __func__, ## args)
+ rte_log(RTE_LOG_ERR, skeleton_eventdev_logtype, \
+ "%s(): " fmt "\n", __func__, ## args)
struct skeleton_eventdev {
uintptr_t reg_base;
--
2.43.0