From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH] app/test: remove ifdefs for cmdline library
Date: Thu, 14 Dec 2023 11:30:21 +0000 [thread overview]
Message-ID: <20231214113021.517622-1-bruce.richardson@intel.com> (raw)
The DPDK unit test binary relies on cmdline library and cannot do
anything without it being present. As it's a mandatory dependency we can
remove the ifdefs for it from main.c
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/test/test.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/app/test/test.c b/app/test/test.c
index bfa9ea52e3..c818fda17b 100644
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -11,13 +11,11 @@
#include <ctype.h>
#include <sys/queue.h>
-#ifdef RTE_LIB_CMDLINE
#include <cmdline_rdline.h>
#include <cmdline_parse.h>
#include <cmdline_socket.h>
#include <cmdline.h>
extern cmdline_parse_ctx_t main_ctx[];
-#endif
#include <rte_memory.h>
#include <rte_eal.h>
@@ -106,12 +104,10 @@ int last_test_result;
int
main(int argc, char **argv)
{
-#ifdef RTE_LIB_CMDLINE
struct cmdline *cl;
char *tests[argc]; /* store an array of tests to run */
int test_count = 0;
int i;
-#endif
char *extra_args;
int ret;
@@ -183,7 +179,6 @@ main(int argc, char **argv)
"HPET is not enabled, using TSC as default timer\n");
-#ifdef RTE_LIB_CMDLINE
char *dpdk_test = getenv("DPDK_TEST");
if (dpdk_test && strlen(dpdk_test) > 0)
@@ -259,7 +254,6 @@ main(int argc, char **argv)
cmdline_interact(cl);
cmdline_stdin_exit(cl);
}
-#endif
ret = 0;
out:
--
2.40.1
next reply other threads:[~2023-12-14 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 11:30 Bruce Richardson [this message]
2023-12-14 17:03 ` Tyler Retzlaff
2024-02-01 10:33 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214113021.517622-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).