From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH] app/test: prevent exiting after skipped test
Date: Thu, 14 Dec 2023 11:38:13 +0000 [thread overview]
Message-ID: <20231214113813.574758-1-bruce.richardson@intel.com> (raw)
When processing a list of tests to run, the loop termination condition
was a test returning a value != 0. This means that if one of a series of
tests was skipped, i.e. returned TEST_SKIPPED, the whole execution run
was stopped. Since a test being skipped is not an error condition, we
put in an explicit check for that to keep executing any remaining tests.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/test/test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test.c b/app/test/test.c
index c818fda17b..8b25615913 100644
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -235,7 +235,7 @@ main(int argc, char **argv)
ret = last_test_result;
end_of_cmd:
- if (ret != 0)
+ if (ret != 0 && ret != TEST_SKIPPED)
break;
}
if (n_skip_tests > 0)
--
2.40.1
next reply other threads:[~2023-12-14 11:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 11:38 Bruce Richardson [this message]
2023-12-14 17:03 ` Tyler Retzlaff
2024-02-01 10:34 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214113813.574758-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).