From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: Nicolas Chautru <nicolas.chautru@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH 2/2] baseband/acc: fix common logs
Date: Mon, 18 Dec 2023 16:43:07 +0100 [thread overview]
Message-ID: <20231218154307.1507322-2-david.marchand@redhat.com> (raw)
In-Reply-To: <20231218154307.1507322-1-david.marchand@redhat.com>
Logs generated by helpers common to acc100 and vrb drivers were
emitted with a RTE_LOG_NOTICE == 6 == RTE_LOGTYPE_HASH.
Register a dedicated logtype for this.
Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/baseband/acc/acc_common.c | 7 +++++++
drivers/baseband/acc/acc_common.h | 4 +++-
drivers/baseband/acc/meson.build | 2 +-
3 files changed, 11 insertions(+), 2 deletions(-)
create mode 100644 drivers/baseband/acc/acc_common.c
diff --git a/drivers/baseband/acc/acc_common.c b/drivers/baseband/acc/acc_common.c
new file mode 100644
index 0000000000..f8d2b19570
--- /dev/null
+++ b/drivers/baseband/acc/acc_common.c
@@ -0,0 +1,7 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2023 Red Hat, Inc.
+ */
+
+#include <rte_log.h>
+
+RTE_LOG_REGISTER_SUFFIX(acc_common_logtype, common, INFO);
diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h
index bda2ad2f7a..fddeb0737b 100644
--- a/drivers/baseband/acc/acc_common.h
+++ b/drivers/baseband/acc/acc_common.h
@@ -150,9 +150,11 @@
#define ACC_MAX_FFT_WIN 16
+extern int acc_common_logtype;
+
/* Helper macro for logging */
#define rte_acc_log(level, fmt, ...) \
- rte_log(RTE_LOG_ ## level, RTE_LOG_NOTICE, fmt "\n", \
+ rte_log(RTE_LOG_ ## level, acc_common_logtype, fmt "\n", \
##__VA_ARGS__)
/* ACC100 DMA Descriptor triplet */
diff --git a/drivers/baseband/acc/meson.build b/drivers/baseband/acc/meson.build
index 449d1e176c..64fcf1537a 100644
--- a/drivers/baseband/acc/meson.build
+++ b/drivers/baseband/acc/meson.build
@@ -24,6 +24,6 @@ endif
deps += ['bus_pci']
-sources = files('rte_acc100_pmd.c', 'rte_vrb_pmd.c')
+sources = files('acc_common.c', 'rte_acc100_pmd.c', 'rte_vrb_pmd.c')
headers = files('rte_acc_cfg.h')
--
2.43.0
next prev parent reply other threads:[~2023-12-18 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 15:43 [PATCH 1/2] baseband/acc: fix logtypes register David Marchand
2023-12-18 15:43 ` David Marchand [this message]
2023-12-18 16:36 ` [PATCH 2/2] baseband/acc: fix common logs Stephen Hemminger
2024-01-12 14:07 ` Maxime Coquelin
2024-02-07 9:19 ` Maxime Coquelin
2023-12-18 16:36 ` [PATCH 1/2] baseband/acc: fix logtypes register Stephen Hemminger
2024-01-12 14:05 ` Maxime Coquelin
2024-02-07 9:18 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218154307.1507322-2-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=nicolas.chautru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).