From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5245443751; Thu, 21 Dec 2023 17:30:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C07E4026B; Thu, 21 Dec 2023 17:30:09 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id B1BAB400D6 for ; Thu, 21 Dec 2023 17:30:07 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d3f2985425so5961115ad.3 for ; Thu, 21 Dec 2023 08:30:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1703176207; x=1703781007; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=xIHR8M+s/b3mctAB1KwhqJTKjA2jJlHMM7FahDqbnvw=; b=QfPCN1LL1ZU4iG5/uC5sYW/HFcFHOh0QTbMqhs+0Jhae7/PnrTl+PObMBNcl90sFId 5G3HtzM7z/aKTKRQI4HZBKRJIo83E6puJKx4gYQh2piEo2iGG4VogHEVIpEqAEhSbmYW g7OILVG7epDeC9Y0ugxt3tkzrVspQ8kvp5CP9rgN4lfjyXVIpamlPuAzZFB2gcT5q+ae w9l5hR7l7eE3NEyDlXF2P+xp148aKHLaRBtPQKjnoKdg6gzCZcOtp/qEhYFSXai3T1jw S3zDgloGmcr22I2hR1rvev6cH13/YuXhJYQo+fYZE88UvprMBWRmsVhe6/VPc6A3xTnf B/mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703176207; x=1703781007; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xIHR8M+s/b3mctAB1KwhqJTKjA2jJlHMM7FahDqbnvw=; b=JuQDjTW8Ujet/MSIrBfuZmp1eLMPdCqLxOvJFH/0CJKQNBcmYW45unONd1yk0sF0yz EmFryp33ehynj3S6HrdHWb3OIms5l+7xqHxaaaQ7yaB1u0s01t8AgqiBOvJ48+f1IFXX pNaLCkvkN1AivdbUSecmJUT7zvXRooBPXb+CeL/fM/W1lTood9jZoiZjufPb1foWNMiS ojQP+b9zfaCddX30J7jkwuxvP2qYTRmRsDE0/Z8HU9T40YKaYLft4al7VFugjt6dNra0 IVgsEEV6v9O5+WGzkhVpyfBJ6NgnHpHuxoP7Spj8OVkVD0J9fY1/MdmOAxa8Y/cUVloc /KXQ== X-Gm-Message-State: AOJu0Ywn5znCFuHlippJ16iKivaHDFVD69uFi80IZkteyZ23KCmtrLTr pee+Oxt6S3uRiliK2d/sVnztJ5Qq/eTkDFUMRpg3aA== X-Google-Smtp-Source: AGHT+IGnGD+dqUo/j+uVTPjyopQ56mQtEmKGIPK/BwQRsU5zUxPHrd35iO0+R73WdhYEK/azgzk2zQ== X-Received: by 2002:a17:903:110f:b0:1d0:81a3:443c with SMTP id n15-20020a170903110f00b001d081a3443cmr11329103plh.113.1703176206745; Thu, 21 Dec 2023 08:30:06 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id z3-20020a170902ee0300b001d3561680aasm1831156plb.82.2023.12.21.08.30.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 08:30:05 -0800 (PST) Date: Thu, 21 Dec 2023 08:30:02 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, ferruh.yigit@amd.com, Thomas Monjalon Subject: Re: [PATCH] devtools: forbid writing to standard output streams Message-ID: <20231221083002.26a46958@hermes.local> In-Reply-To: <20231221133120.1654941-1-david.marchand@redhat.com> References: <20231221133120.1654941-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 21 Dec 2023 14:31:20 +0100 David Marchand wrote: > No output on stdout or stderr! > Drivers and libraries must use the logging framework. > > Signed-off-by: David Marchand > --- > devtools/checkpatches.sh | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index 10d1bf490b..c9e466f736 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -61,6 +61,14 @@ check_forbidden_additions() { # > -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > "$1" || res=1 > > + # no output on stdout or stderr > + awk -v FOLDERS="lib drivers" \ > + -v EXPRESSIONS="\\\ \\\ + -v RET_ON_FAIL=1 \ > + -v MESSAGE='Writing to stdout or stderr' \ > + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > + "$1" || res=1 > + > # refrain from new additions of rte_panic() and rte_exit() > # multiple folders and expressions are separated by spaces > awk -v FOLDERS="lib drivers" \ Ok, noticed a lot of this in the crypto drivers dump code. Probably other drivers have buried debug code as well.