From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id C38D05595 for ; Thu, 29 Sep 2016 18:45:57 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id w72so38361840wmf.1 for ; Thu, 29 Sep 2016 09:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q+IiWCZWlvnJ0h4kchn+3639dbV4PiF6e1Iq4g8KX5Y=; b=n3ryo8VfvFAoITNTcMIUzcQ857VRR0qExq0GsanwFjwkFiPnoIAhYwkkooZ/Oe5Bcs mdJ/W2yVLoRBNOwDlzkWsldLtxlnYFqgDIv6K617bFy9kfm/xPVhEPErZ6N0+l1rfTew Gkw23bMqzEIRvmH8AdHNAZBP0RD6yK1pP9vcuTQLUhk1EGHxMadGcg2uIAkaa7iNEav3 09N187lt1KWOA9R84//SlyRcGnACt/CP/oD3AIyN8dEeKnDkIgqKj5isof6xFOSv3Pyy oThjpZGzJidRlbssbXXltxEw7cHBBwcfzcXbm+yaLuUq7MguMgs9/JATvlNe5xpZvp1+ YPjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Q+IiWCZWlvnJ0h4kchn+3639dbV4PiF6e1Iq4g8KX5Y=; b=kq6TaMeKDNWOW1L9feMpD9Ov/hJmw+LjcfXfxQXJpERloMXt7Ov/EmEAzvmCdDIz9v g7M7y/amKhoT8Hk/9JZYVX8TNjBllwNhPsiIp1pUXDyMVua6BM0rAWmS1yTFWAt7Au8w JoE4NjlxExgUrsObttF6iIKW1f2W+mSiOW18DSgSRa6pd6XYRi/5a8STqP1o8SU6zJrw AU5E10lvhEvU4VmGYflLUXNFYsZNgzXFP/xZ8S7+nNFJSEDBnbZh/ilbeWCKM7Z3Bve/ q0piNjCldiHVQEWyf11kkQb6BtAw6VHex+ucdUCsKg6GaSEnv1yScZ4VVUMLsX6F6Q/E OK9A== X-Gm-Message-State: AA6/9RlsnfoczSqyjJ3yz6do0xqeK1bUnQBLbYIbVbCdQ4N+YSgGqmUqtVOAihOSu34k0ZZh X-Received: by 10.194.84.199 with SMTP id b7mr2329551wjz.147.1475167557563; Thu, 29 Sep 2016 09:45:57 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id a84sm29350623wme.6.2016.09.29.09.45.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Sep 2016 09:45:56 -0700 (PDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: dev@dpdk.org, "Shah, Rahul R" , "Lu, Wenzhuo" , "az5157@att.com" , azelezniak Date: Thu, 29 Sep 2016 18:45:56 +0200 Message-ID: <20232837.4O4ehj9xGN@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A08E198@IRSMSX108.ger.corp.intel.com> References: <1474453204-31516-1-git-send-email-bernard.iremonger@intel.com> <1953384.ANuSY1Omf7@xps13> <8CEF83825BEC744B83065625E567D7C21A08E198@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 16:45:57 -0000 2016-09-29 16:38, Iremonger, Bernard: > Hi Thomas, > > > Subject: Re: [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF > > management > > > > 2016-09-29 15:16, Iremonger, Bernard: > > > > 2016-09-29 15:16, Bernard Iremonger: > > > > > +int > > > > > +rte_eth_dev_set_vf_vlan_stripq(uint8_t port, uint16_t vf, int > > > > > +on); > > > > > > > > Why keeping this function in ethdev? > > > > > > This function is using an existing API in the eth_dev_ops structure. > > > > > > dev->dev_ops->vlan_strip_queue_set > > > > > > The vlan_strip_queue_set API is used by the i40e, ixgbe and mlx5 PMD's. > > > > OK but it was not used to control VF from PF. > > This line: > > (*dev->dev_ops->vlan_strip_queue_set)(dev, q + vf * > > queues_per_pool, on); seems Intel specific. > > Please keep "VF from PF" outside of ethdev for 16.11. > > I will try calling (*dev->dev_ops->vlan_strip_queue_set) from an ixgbe-specific function. > Will this be acceptable? I think it is acceptable.