From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0983432AF; Fri, 5 Jan 2024 23:00:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF6CE402E0; Fri, 5 Jan 2024 23:00:09 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 353D6402DC for ; Fri, 5 Jan 2024 23:00:09 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d4ba539f6cso11025ad.3 for ; Fri, 05 Jan 2024 14:00:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1704492008; x=1705096808; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Si8PPlQL0RiFz+xUO3Ylyf91HCnoJ8l0ZyR1YNPIKO4=; b=HshIymc6QCzW7htaTVMIzEJHQUMIqHsA6PGZ9RzJoPkTD3ySAUzvkvPXwLpgF3Yjom qIvmo+BD/V4jQPPEI6akAUYHRhd5GY5Ad7OHKgq8NWHrS36I59RnCeo3C91BRtSaGPms wlXKrLG3e6HVkIhegXCcwsCGUTuneIpGHYbRPNDcJmAlHA3HjJ0uShIHAw5VB0Vx1f/a 0XdYaC1tqMfrDy+ilsnDdKs4GKORzR/RFg60/yTPTGP+P3gQ6SB1t9u/NFHDnd6SAn/H 5y+hx123Z9OYBY2NilbSMebZ2HsTkUVoFCXCE6IuoD93AcJsdleyD0Z5y0OI/Fl44oQ8 rrMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704492008; x=1705096808; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Si8PPlQL0RiFz+xUO3Ylyf91HCnoJ8l0ZyR1YNPIKO4=; b=Idd3gHi0wV7hDPJvy4bRJxBnJgv/sjOZN1j9TrxmWVmGe7ocQngPv2vW5d8yD2kmJA qL/VkFIDAIAMGjoh8RGTIhuIa5TF2xvoZzEYHXoUvisfme4MSW79x4MJ+mZHCgWh8/Gd kfMMjBc901kqB/IM6xvRW2lg4Cx5hSkofbxd98oj4IVp5s9U9w4GajvkV81QkKn1w4x7 V/7KvKA7+v9qjTdfEVCQ+laqGJQR2zJxniuelE7KIj/VYGUXRIEo8ECEXFSrpgGoNNTa QiQjh4DqsZ4U7HSkSmBBdmQiBO0t2dJVDh+8OzE8ZUUXUPN0c9ex46wAJlBjVrppSSoF uM9w== X-Gm-Message-State: AOJu0Yw5+AHAOxrCeX5DsqEGVuLOjPGCL4N/BSsbzQWG7Ptprt4uRKnz 2R8uvbU85f079rD3GmUXYAgHbralO5SbMA== X-Google-Smtp-Source: AGHT+IGuiUE6wj8AcyDD0HDvhis+N1LczaVvNOgQNJQdZIemfV09h7SPPtg1uLiGsH8IN+F0Ph80fw== X-Received: by 2002:a17:903:228f:b0:1d3:ea5c:bfd8 with SMTP id b15-20020a170903228f00b001d3ea5cbfd8mr150070plh.62.1704492008196; Fri, 05 Jan 2024 14:00:08 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id v5-20020a170902b7c500b001d3e51eabb3sm1842785plz.225.2024.01.05.14.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 14:00:08 -0800 (PST) Date: Fri, 5 Jan 2024 14:00:04 -0800 From: Stephen Hemminger To: Hernan Vargas Cc: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com, nicolas.chautru@intel.com, qi.z.zhang@intel.com Subject: Re: [PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for consistency Message-ID: <20240105140004.7389f645@hermes.local> In-Reply-To: <20240105211519.185086-2-hernan.vargas@intel.com> References: <20240105211519.185086-1-hernan.vargas@intel.com> <20240105211519.185086-2-hernan.vargas@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 5 Jan 2024 13:15:16 -0800 Hernan Vargas wrote: > +#define FPGA_5GNR_QUEUE_FLUSH_TIMEOUT_US (1000) Just my opinion, no need it doesn't have to change but. These variable names are getting quite long which doesn't improve readability.