From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24ED64387A; Wed, 10 Jan 2024 00:55:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED275402DD; Wed, 10 Jan 2024 00:55:31 +0100 (CET) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by mails.dpdk.org (Postfix) with ESMTP id 6DF34402CE for ; Wed, 10 Jan 2024 00:55:30 +0100 (CET) Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3bbd1f9e0b8so2854138b6e.0 for ; Tue, 09 Jan 2024 15:55:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1704844529; x=1705449329; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=y8Sx61Zncn7FwPfZBHUFud9YyhwbLbfmme8LUCtN8vQ=; b=R2m4J3Xupu0nm9fJBZfLsLEvHWwePJ/PNT1GsVdhj9sAeIAoky2XPz+FBVmW946Bln tWgqdu6OWG3fB257c/aO2poMJabhOGSdK8tWizZefcasytyyMdPXXbQMGiYdL4ziHBRS qbbNDLq3o59NxIJ+/366FQRRBqMu2u1Pi0i/z9Yno/3a22Xnt1PKQ8vLPDJ+bcUNZIJE eVWTTgmQAgLu5l1QTzDoKSU/EVJ9Bcw8Gkzo/QnLX/wQWWWsjATMc5oBe7FF03ZpWtkq B/KUVijmpo2lJHPosOy1J3A/ZeGDBZe9z100fCARbdf55mlqiFwgpoBPxg8Tt4nKH/YA 0XMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704844529; x=1705449329; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y8Sx61Zncn7FwPfZBHUFud9YyhwbLbfmme8LUCtN8vQ=; b=GOPNMnm9Int0ulDDHhr2E28DWZpJZGdkmbMf5HPS1ClcqA2KiI5Y2HNeWHzmTL8dOY gSVYEnvauBg7djkSvYwViXvxvsGuLp/o6V03DoTpZz/4ACvZJRBdqiQ5ncuNcXXFaONj 4n/ibNlfBXp+lnYQiKmjbfdp7km8HtH39afwxNolCsCfBCzM+EFfHrBZI3TDAdpp31UG O620vhWZyWzx8CAHqnowzVOzbpKJi2qUBZm0mxUgPCTNnnarb0/6PcQFFNE/XhC/vJEU tq9ERE8Bh36UcO2ez9qrSwNWqOWbj1UKDPcnWOrSBSXzw2ffYwzeY4DQmRWi7BSrDZDg GKcA== X-Gm-Message-State: AOJu0YyG1C9TwQlzYyi9WYxQeC5AV3vmEuKu/vufvVRBAnOqvU08tCBX okd+pODqZPBxosSazFFID111V7aQTi1+1Q== X-Google-Smtp-Source: AGHT+IGRsmbFGbpLF/14jvMtJsPshlAxAN7bffcgarSoSMlJWJ9nrI71qMYQryJ0sAzp4lWP00gSkQ== X-Received: by 2002:a05:6808:1506:b0:3bd:4169:bc88 with SMTP id u6-20020a056808150600b003bd4169bc88mr263469oiw.39.1704844529671; Tue, 09 Jan 2024 15:55:29 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j10-20020a056a00234a00b006da0372200asm2199376pfj.184.2024.01.09.15.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 15:55:29 -0800 (PST) Date: Tue, 9 Jan 2024 15:55:27 -0800 From: Stephen Hemminger To: Bruce Richardson Cc: Lewis Donzis , Konstantin Ananyev , dev , "Wang, Yong" Subject: Re: vmxnet3 no longer functional on DPDK 21.11 Message-ID: <20240109155527.7eed113e@hermes.local> In-Reply-To: References: <2134779104.413217.1638218715124.JavaMail.zimbra@donzis.com> <1909271468.2730688.1638755553311.JavaMail.zimbra@donzis.com> <1796133353.5470017.1654262374494.JavaMail.zimbra@donzis.com> <12922153.12944.1704552603431.JavaMail.zimbra@donzis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 9 Jan 2024 10:21:04 +0000 Bruce Richardson wrote: > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index e49191718a..d088b42d35 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -1129,6 +1129,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev) > /* Setting proper Rx Mode and issue Rx Mode Update command */ > vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1); > > +#ifndef RTE_EXEC_ENV_FREEBSD > /* Setup interrupt callback */ > rte_intr_callback_register(dev->intr_handle, > vmxnet3_interrupt_handler, dev); > @@ -1140,6 +1141,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev) > > /* enable all intrs */ > vmxnet3_enable_all_intrs(hw); > +#endif > > vmxnet3_process_events(dev); > Probably need to go further with this. - what about unreigster in vmxnet3_dev_stop - vmxnet3_interrupt_handler is then dead code, should it be #ifdef guarded? - and vmxnet3_dev_rx_queue_intr_enable/disable - and vmxnet3_enable_intr - and vmxnet3_configure_msix - and checks for rte_eth_intr_conf bits? in configure