From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC6114388B; Fri, 12 Jan 2024 17:41:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8C03402C5; Fri, 12 Jan 2024 17:41:34 +0100 (CET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 87556402AD for ; Fri, 12 Jan 2024 17:41:33 +0100 (CET) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6d9b267007fso4240431b3a.3 for ; Fri, 12 Jan 2024 08:41:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1705077693; x=1705682493; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=xj3ap8MiiHQnWthxKybuzQswYfGHMmIIJAcjcQIMqDk=; b=GXBoltg2jTlvS/WguVCGUmRcHaxwQahAJqUnMVKF/QPnctxoZEZXrcSOHSm6OsPdkA 5jYYMtd32c/lOXm7Zjglu/5X9dLHe4rg1D+KvUpX6UkIyME4ivkXZOx5DZxGVCcFJVYU B5JZBAh0NEu+P4+FqTgzEhJsfn11I8uKatdPUzt0321Cd/tWTix8sqiWLPCPfsaa+AXH SLZBo+JhCI+eyfqQcl9IGdO7eLePy9ocFFNZ/adEHEhItFK/xdqWNtl4xKVeADF7LFho nJIl/E6QDqHCSSq/1rMuTbq1pjVv9s2Jx8dFWLaQIdJ7ai2USKhvU1P5Dh0avfwRynRQ eW+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705077693; x=1705682493; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xj3ap8MiiHQnWthxKybuzQswYfGHMmIIJAcjcQIMqDk=; b=vlqOTE4o0ZzjksJt7vQt8xGzRzhecpJ2hHq+soOmCA5TTB6yWmwEacQ6iKYkWamy16 KHWSyl/v3NWl6JnN7kLoM4fO7o8BjpFA2sqpXskCAeDAr/1n4KaMCRfxjlvfCzfEmGNj U+/PksrOlZ2irzvRANQFMTRHK0Eg9PfasqB+paniy9IBlkD9EniiOOhP9TMlRFnXUcfE mNKLAJVMs98C45/8gnKtCArZms1UXQ9zLN6inXeTacwhwIGkT2MDHPz9CyiuhL3uq1JW G0iDR85L6ALpamXDuJoBtEtJqmMfdRZgy2eIvPO/o7TLzAMWc5HSJus9x5xUTmzxHzw4 EJqQ== X-Gm-Message-State: AOJu0YySJEDvcyFwoJZUSIm1ow1C5HTIYLeUp4SGsDnURJfef0qHgEJC yYCnijh4wKbiZGDkzwP97IFfODd8jH6Kh8yf3n2IH3x6Cclz6Ula X-Google-Smtp-Source: AGHT+IEuqchTEYVRtMGDoWSsNhIiV0FR4Sf+k3q3yLERnEl0sTlfUZvNS3me6GGdNA1eLRMa/tnXug== X-Received: by 2002:a05:6a20:12d2:b0:194:f67b:e499 with SMTP id v18-20020a056a2012d200b00194f67be499mr1100946pzg.98.1705077692866; Fri, 12 Jan 2024 08:41:32 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id px8-20020a17090b270800b0028dc4b598b7sm6245146pjb.55.2024.01.12.08.41.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 08:41:32 -0800 (PST) Date: Fri, 12 Jan 2024 08:41:31 -0800 From: Stephen Hemminger To: madhuker.mythri@oracle.com Cc: dev@dpdk.org, ferruh.yigit@amd.com Subject: Re: [PATCH] net/tap: Modified TAP BPF program as per the Kernel-version upgrade requirements. Message-ID: <20240112084131.1786113c@hermes.local> In-Reply-To: <20240112134821.2067-1-madhuker.mythri@oracle.com> References: <20240112134821.2067-1-madhuker.mythri@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 12 Jan 2024 19:18:21 +0530 madhuker.mythri@oracle.com wrote: > - queue = rsskey->queues[(hash % rsskey->nb_queues) & > - (TAP_MAX_QUEUES - 1)]; > - skb->cb[1] = QUEUE_OFFSET + queue; > - /* printt(">>>>> rss_l3_l4 hash=0x%x queue=%u\n", hash, queue); */ > + hash = (hash % rsskey->nb_queues) & (TAP_MAX_QUEUES - 1); > +#pragma clang loop unroll(full) > + for (k = 0; k < TAP_MAX_QUEUES; k++) { > + if(k == hash) > + queue = rsskey->queues[k]; > + } > Why introduce another loop here. Original code was fine and bounded.